All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tzafrir Cohen <tzafrir.cohen@xorcom.com>
To: linux-kernel@vger.kernel.org
Cc: Greg KH <greg@kroah.com>,
	OSLEC list <freetel-oslec@lists.sourceforge.net>
Subject: [PATCH] fix Pstate growing in OSLEC
Date: Thu, 18 Jun 2009 20:45:40 +0300	[thread overview]
Message-ID: <20090618174540.GT3311@xorcom.com> (raw)

The following fix has been posted in the OSLEC mailing list by Ruslan
Cray (and shortly afterwards acepted into the OSLEC SVN tree). Sadly it
has not been forwarded the kernel.org tree until now.

See:

http://sourceforge.net/mailarchive/forum.php?thread_name=000b01c9d88f%24ec689690%2475a8a8c0%40rcraydvlpmnt&forum_name=freetel-oslec

As a side note, the OSLEC code is gathering dust in the staging tree.
As-is it is mostly useless without providing an interface for its code.
I was hoping to see the mISDN code starting to use it but so far no 
change in that front.

---
 drivers/staging/echo/echo.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/echo/echo.c b/drivers/staging/echo/echo.c
index 6d7217e..faab26d 100644
--- a/drivers/staging/echo/echo.c
+++ b/drivers/staging/echo/echo.c
@@ -395,7 +395,7 @@ int16_t oslec_update(struct oslec_state *ec, int16_t tx, int16_t rx)
 		old = (int)ec->fir_state.history[ec->fir_state.curr_pos] *
 		    (int)ec->fir_state.history[ec->fir_state.curr_pos];
 		ec->Pstates +=
-		    ((new - old) + (1 << ec->log2taps)) >> ec->log2taps;
+		    ((new - old) + (1 << (ec->log2taps - 1))) >> ec->log2taps;
 		if (ec->Pstates < 0)
 			ec->Pstates = 0;
 	}
-- 
1.5.6.5


-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen@xorcom.com
+972-50-7952406           mailto:tzafrir.cohen@xorcom.com
http://www.xorcom.com  iax:guest@local.xorcom.com/tzafrir

             reply	other threads:[~2009-06-18 18:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-18 17:45 Tzafrir Cohen [this message]
2009-06-18 20:54 ` [freetel-oslec] [PATCH] fix Pstate growing in OSLEC David Rowe
2009-06-18 21:09   ` Tzafrir Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090618174540.GT3311@xorcom.com \
    --to=tzafrir.cohen@xorcom.com \
    --cc=freetel-oslec@lists.sourceforge.net \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.