From: Paul Mundt <lethal@linux-sh.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-kernel@vger.kernel.org, David Howells <dhowells@redhat.com>,
David McCullough <davidm@snapgear.com>,
Greg Ungerer <gerg@uclinux.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] rmap: fixup page_referenced() for nommu systems
Date: Fri, 19 Jun 2009 11:26:16 +0900 [thread overview]
Message-ID: <20090619022616.GA16806@linux-sh.org> (raw)
In-Reply-To: <1245371813-30954-1-git-send-email-vapier@gentoo.org>
On Thu, Jun 18, 2009 at 08:36:53PM -0400, Mike Frysinger wrote:
> After the recent changes that went into mm/vmscan.c to overhaul stuff, we
> ended up with these warnings on no-mmu systems:
> mm/vmscan.c: In function ???shrink_page_list???:
> mm/vmscan.c:580: warning: unused variable ???vm_flags???
> mm/vmscan.c: In function ???shrink_active_list???:
> mm/vmscan.c:1294: warning: ???vm_flags??? may be used uninitialized in this function
> mm/vmscan.c:1242: note: ???vm_flags??? was declared here
>
> This is because the no-mmu function defines page_referenced() to work on
> the first argument only (the page). It does not clear the vm_flags given
> to it because for no-mmu systems, they never actually get utilized. Since
> that is no longer strictly true, we need to set vm_flags to 0 like everyone
> else so gcc can do proper dead code elimination without annoying us with
> unused warnings.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Looks ok to me.
Acked-by: Paul Mundt <lethal@linux-sh.org>
next prev parent reply other threads:[~2009-06-19 2:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-19 0:36 [PATCH] rmap: fixup page_referenced() for nommu systems Mike Frysinger
2009-06-19 2:26 ` Paul Mundt [this message]
2009-06-19 10:58 ` David Howells
2009-06-22 7:35 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090619022616.GA16806@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=davidm@snapgear.com \
--cc=dhowells@redhat.com \
--cc=gerg@uclinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.