Re: [PATCH] tools: don't require hardcoded path in guest config file

[Christoph Egger <Christoph.Egger@amd.com>]

On Friday 19 June 2009 17:16:42 Ian Jackson wrote:
> Christoph Egger writes ("[Xen-devel] [PATCH] tools: don't require hardcoded 
path in guest config file"):
> > Attached patch allows xen tools to no longer require the hardcoded path's
> > to hvmloader, qemu-dm and stubdom-dm in the guest config files.
>
> In general I think this is a great idea.
> I just have some detailed quibbles.
>
> > +            if not os.path.exists(self['platform']['device_model']):
> > +                self['platform']['device_model'] = \
> > +                    auxbin.pathTo(self['platform']['device_model'])
>
> I think it would be better just to look for a slash in the specified
> value, and always prepend the path.  Otherwise you end up checking for
> the file in xend's cwd which is pretty strange behaviour.
>
> Treating all /-less values as paths in the expected installation
> directory is more sensible.

Ok.

> > +                    # XXX basename works around a bug somewhere in the 
guest
> > +                    # config file parser which prepends cwd to the kernel 
> > +                   # w/o checking if the result is valid if no  absolute
> > +                    # path is specified 
>
> Surely it would be better to fix the guest config file parser!

Right. But I didn't find the exact place where the cwd is actually prepended.
It would be great, if you can help out here.

> > +                    if os.path.basename(self['PV_kernel']) 
==  'hvmloader':
>
> That workaround is a pretty hideous hack.

Yes, it is.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632