All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: Lorenz Kolb <lorenz@missinglinkelectronics.com>
Cc: linuxppc-dev@ozlabs.org, Fahd Abidi <fabidi@ultsol.com>
Subject: Re: Problem with memcpy on ppc8536
Date: Fri, 19 Jun 2009 19:51:05 +0200	[thread overview]
Message-ID: <20090619175105.GA16015@pengutronix.de> (raw)
In-Reply-To: <4A3BC58A.7050408@missinglinkelectronics.com>

[-- Attachment #1: Type: text/plain, Size: 773 bytes --]

On Fri, Jun 19, 2009 at 07:06:18PM +0200, Lorenz Kolb wrote:

> Could you please try the following patch, I am quite sure that checking  
> for > 4 was accidentially done within io.c instead of >= 4 as if it's 4  
> we still can copy a 32-bit word. Some hardware might not be happy about  
> 8-bit accesses...

There seems to be desire for this fix:

http://lists.ozlabs.org/pipermail/linuxppc-dev/2009-May/072582.html

If it works here, too, then you could maybe also ack it?

BTW, I can't find the original patch in patchwork, maybe the patch was missed
because of that?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  parent reply	other threads:[~2009-06-19 17:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <71DEA556544D7A4F9C6848402D8184340C4A13__24467.8549039692$1245370891$gmane$org@usi01.ultsol.local>
2009-06-19 17:04 ` Problem with memcpy on ppc8536 Lorenz Kolb
2009-06-19 17:06 ` Lorenz Kolb
2009-06-19 17:28   ` Albrecht Dreß
2009-06-19 17:51   ` Wolfram Sang [this message]
2009-06-18 20:33 Fahd Abidi
2009-06-19  4:42 ` Liu Dave-R63238

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090619175105.GA16015@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=fabidi@ultsol.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=lorenz@missinglinkelectronics.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.