All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2 V2] Move libgcc inclusion from common Makefile to platform configs files
Date: Sat, 20 Jun 2009 08:57:41 -0400	[thread overview]
Message-ID: <200906200857.42360.vapier@gentoo.org> (raw)
In-Reply-To: <20090620113041.GE6870@game.jcrosoft.org>

On Saturday 20 June 2009 07:30:41 Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 07:08 Sat 20 Jun     , Mike Frysinger wrote:
> > On Saturday 20 June 2009 06:40:07 Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > On 06:18 Sat 20 Jun     , Mike Frysinger wrote:
> > > > On Saturday 20 June 2009 05:33:26 Jean-Christophe wrote:
> > > > > This patch moves the libgcc Makefile inclusion from the toplevel
> > > > > Makefile to the arch_config.mk files. This is in preparation for
> > > > > the ARM architecture to move away from including libgcc function
> > > > > and only using self-contained U-Boot functions as done in Linux.
> > > >
> > > > why not change the top level Makefile to read:
> > > > PLATFORM_LIBGCC ?= ...
> > > >
> > > > then any board/arch that doesnt want it can simply do:
> > > > PLATFORM_LIBGCC = # dont want it
> > >
> > > because you need to provide the equivalent functions for standalone
> > > application and api and U-Boot ofcourse
> >
> > so move it to config.mk.  this doesnt change the important point: leave
> > PLATFORM_LIBGCC default in the toplevel common files.  what i proposed
> > doesnt limit what you want to do with arm in any way.
>
> I think it's better to let it at arch level and force any new arch adding
> to manage it instead provide a default one

considering most arches want this code, i dont think so.  you're proposing we 
duplicate the same common code in all arches to support one deviating arch -- 
arm.  the defaults should reflect the common state while the deviating ones 
change the behavior as they like.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090620/89cd12ea/attachment.pgp 

  reply	other threads:[~2009-06-20 12:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-20  9:33 [U-Boot] [PATCH 1/2 V2] Move libgcc inclusion from common Makefile to platform configs files Jean-Christophe PLAGNIOL-VILLARD
2009-06-20  9:33 ` [U-Boot] [PATCH 2/2 V2] ARM: Don't include libgcc anymore Jean-Christophe PLAGNIOL-VILLARD
2009-06-21 12:25   ` Dirk Behme
2009-06-20 10:18 ` [U-Boot] [PATCH 1/2 V2] Move libgcc inclusion from common Makefile to platform configs files Mike Frysinger
2009-06-20 10:40   ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-20 11:08     ` Mike Frysinger
2009-06-20 11:30       ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-20 12:57         ` Mike Frysinger [this message]
2009-06-20 13:01           ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-20 13:33             ` Mike Frysinger
2009-06-20 13:57               ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-20 15:59                 ` Mike Frysinger
2009-06-20 17:15                   ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-10 22:27                     ` Wolfgang Denk
2009-06-22 18:55                 ` Scott Wood
2009-07-04 21:52 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906200857.42360.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.