From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Dan Aloni <dan@aloni.org>
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@suse.de>
Subject: Re: [PATCH] Staging: prevent rtl8187se from crashing dev_ioctl() in SIOCGIWNAME
Date: Sat, 20 Jun 2009 22:51:16 +0200 [thread overview]
Message-ID: <200906202251.16916.bzolnier@gmail.com> (raw)
In-Reply-To: <20090620133222.GA18731@localhost>
On Saturday 20 June 2009 15:32:22 Dan Aloni wrote:
> I repeatedly get __stack_chk_fail panic()s with this driver before
> applying the attached fix.
>
> ieee80211_wx_get_name() ignores sizeof(wrqu->name) which is IFNAMSIZ (16), and
> on certain conditions, the concatenated string will be larger than IFNAMSIZ
> including the terminating zero.
>
> length ("802.11" ++ "b" ++ "/g" ++ " linked" ++ "\x00") == 17
>
> This fix uses strl{cpy,cat} in addition to the reduction of the total
> possible length of the output string by a char.
>
> It can be applied to 2.6.30-stable as well.
Recently added rtl8192su driver seems to also need it, care to port the fix?
(http://patchwork.kernel.org/patch/29630/ is needed to build rtl8192su ATM)
next prev parent reply other threads:[~2009-06-20 20:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-20 13:32 [PATCH] Staging: prevent rtl8187se from crashing dev_ioctl() in SIOCGIWNAME Dan Aloni
2009-06-20 20:51 ` Bartlomiej Zolnierkiewicz [this message]
2009-06-24 19:34 ` [PATCH] prevent rtl8192su from crashing dev_ioctl " Dan Aloni
2009-06-25 14:34 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906202251.16916.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=dan@aloni.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.