Re: [PATCH] fix building bug with --enable-grub-emu-usb

[Robert Millan <rmh@aybabtu.com>]

On Fri, Jun 19, 2009 at 11:46:06AM -0400, Pavel Roskin wrote:
> 
> Generally, please think how to reduce complexity, not how to add to it.
> Complex systems are harder to maintain.

In general, I completely agree with this.

However grub-emu has very special requirements that could make it desireable
sometimes.  Its purpose is to emulate GRUB as faithfully as possible to
uncover bugs so in general we want to use interfaces as lower as possible
_but_ it's sometimes useful to be able to isolate those bugs, which makes
options to choose between higher or lower interfaces also desireable.

For example, should we use our USB drivers against libusb, or should we
ditch libusb and use our *HCI controllers against libpci?  Should we use
our gfxterm against SDL, or should we use our own hardware drivers to
access the hardware (sort of) directly like X does?

I think we need some balance here, and decide on a case by case basis.

Anyway, given that grub-emu is a debugging/development tool, I'm not sure
it's that useful to export those flags to autoconf.  We could just live
with #ifdefs in the code IMHO.  Distributors are going to ship whatever we
choose as default for grub-emu anyway.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."