From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MISg7-0007ov-A0 for mharc-grub-devel@gnu.org; Sun, 21 Jun 2009 15:26:11 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MISg6-0007oi-JV for grub-devel@gnu.org; Sun, 21 Jun 2009 15:26:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MISg2-0007np-1D for grub-devel@gnu.org; Sun, 21 Jun 2009 15:26:10 -0400 Received: from [199.232.76.173] (port=58350 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MISg1-0007nk-RX for grub-devel@gnu.org; Sun, 21 Jun 2009 15:26:05 -0400 Received: from mx20.gnu.org ([199.232.41.8]:27998) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MISg1-00024C-G7 for grub-devel@gnu.org; Sun, 21 Jun 2009 15:26:05 -0400 Received: from aybabtu.com ([69.60.117.155]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MISg0-0002IV-UG for grub-devel@gnu.org; Sun, 21 Jun 2009 15:26:05 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MIRd0-0004cm-0n for grub-devel@gnu.org; Sun, 21 Jun 2009 20:18:54 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MISfr-0005hq-K1 for grub-devel@gnu.org; Sun, 21 Jun 2009 21:25:55 +0200 Date: Sun, 21 Jun 2009 21:25:55 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090621192555.GB21827@thorin> References: <20090621181748.GA21152@thorin> <20090621185444.GA21590@thorin> <1245611156.4250.11.camel@mj> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1245611156.4250.11.camel@mj> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-Detected-Operating-System: by mx20.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] move grub_stop() (Re: [PATCH] i386-qemu port) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Jun 2009 19:26:10 -0000 On Sun, Jun 21, 2009 at 03:05:56PM -0400, Pavel Roskin wrote: > On Sun, 2009-06-21 at 20:54 +0200, Robert Millan wrote: > > Move grub_stop to init.c to ease code sharing with i386-qemu. > > That's not quite a movement. grub_cpu_idle() does nothing. Well, the major problem with grub_cpu_idle() doing nothing on coreboot is CPU consumption during polls. grub_stop() is quite a corner case, only seen when you hit an error. > I think we need to have several implementations of grub_stop: hard halt > with interrupts disabled, exit from qemu, exit from other emulators if > it's different, power off, exit to BIOS. Then different platforms > should enable and try whatever is appropriate for them. Note that we already have: grub_stop: Just hang. grub_exit: Exit to BIOS/whatever. On coreboot (and on i386-qemu) there's really no "proper" thing to do. Maybe fallback to grub_halt or grub_fatal. grub_halt: Power off. Theoretically we can have it anywhere, although in some platforms like coreboot it's not easy; otherwise it can fallback to grub_stop. I think grub_stop is intended to have this behaviour in all platforms. But I'm not sure how useful is it. Perhaps it could be ditched in favour of grub_exit? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."