From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MIgkl-0005Uz-UL for mharc-grub-devel@gnu.org; Mon, 22 Jun 2009 06:27:55 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIgki-0005Ty-P9 for grub-devel@gnu.org; Mon, 22 Jun 2009 06:27:52 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIgkd-0005Ry-MS for grub-devel@gnu.org; Mon, 22 Jun 2009 06:27:52 -0400 Received: from [199.232.76.173] (port=33930 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIgkc-0005RS-RM for grub-devel@gnu.org; Mon, 22 Jun 2009 06:27:47 -0400 Received: from aybabtu.com ([69.60.117.155]:49413) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MIgkb-0001cm-Tb for grub-devel@gnu.org; Mon, 22 Jun 2009 06:27:46 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MIfhd-0006yn-G9 for grub-devel@gnu.org; Mon, 22 Jun 2009 11:20:37 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MIgkZ-0005N7-8v for grub-devel@gnu.org; Mon, 22 Jun 2009 12:27:43 +0200 Date: Mon, 22 Jun 2009 12:27:43 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090622102743.GF8969@thorin> References: <20090621181748.GA21152@thorin> <20090621191934.GA21827@thorin> <1245637204.9864.78.camel@mj> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1245637204.9864.78.camel@mj> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: [PATCH] rename kernel.elf to kernel.img (Re: [PATCH] i386-qemu port) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2009 10:27:53 -0000 On Sun, Jun 21, 2009 at 10:20:04PM -0400, Pavel Roskin wrote: > On Sun, 2009-06-21 at 21:19 +0200, Robert Millan wrote: > > If you check my earlier patch, you'll see i386-qemu.rmk is just a stub > > that includes i386-coreboot.rmk. This is to reduce code duplication > > (untill we have a more flexible build system). > > > > This patch renames kernel.elf to kernel.img in ELF platforms, so that > > more variables / etc can be shared with non-ELF ones. > > No objections as long as it compiles without warnings. Sharing more > code is a good thing. > > By please note that I had to add kernel_elf_ASFLAGS in > i386-ieee1275.rmk, or with would not compile on x86_64, as some compiler > invocations would miss -m32. So you patch will need to be adjusted for > that. Updated, verified warning-free and committed. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."