From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MIh1b-00072L-Qj for mharc-grub-devel@gnu.org; Mon, 22 Jun 2009 06:45:19 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIh1Z-000727-5y for grub-devel@gnu.org; Mon, 22 Jun 2009 06:45:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIh1U-00071E-NB for grub-devel@gnu.org; Mon, 22 Jun 2009 06:45:16 -0400 Received: from [199.232.76.173] (port=47971 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIh1U-00071B-JL for grub-devel@gnu.org; Mon, 22 Jun 2009 06:45:12 -0400 Received: from aybabtu.com ([69.60.117.155]:50906) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MIh1U-0005rG-76 for grub-devel@gnu.org; Mon, 22 Jun 2009 06:45:12 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MIfyV-0006zc-Mq for grub-devel@gnu.org; Mon, 22 Jun 2009 11:38:04 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MIh1R-0002hB-If for grub-devel@gnu.org; Mon, 22 Jun 2009 12:45:09 +0200 Date: Mon, 22 Jun 2009 12:45:09 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090622104509.GG8969@thorin> References: <20090621181748.GA21152@thorin> <20090621195237.GA23624@thorin> <1245635802.9864.60.camel@mj> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1245635802.9864.60.camel@mj> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: [PATCH] swap real_to_prot() and prot_to_real() (Re: [PATCH] i386-qemu port) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2009 10:45:17 -0000 On Sun, Jun 21, 2009 at 09:56:42PM -0400, Pavel Roskin wrote: > On Sun, 2009-06-21 at 21:52 +0200, Robert Millan wrote: > > When doing the i386-coreboot port I made this choice completely backwards. > > > > I thought real_to_prot() was only useful on i386-pc, because we needed it > > for returning from BIOS, and prot_to_real() was useful elsewhere, because > > the Linux loader would use it. > > > > Turns out we need real_to_prot() on i386-qemu for the initial transition > > to i386 mode, AND we don't need prot_to_real() anywhere other than i386-pc, > > because OSes that expect to be loaded in i8086 mode are going to rely on > > BIOS calls. > > > > So this patch swaps them. real_to_prot() goes to realmode.S and > > prot_to_real() back to startup.S. > > You have my approval as long as it compiles and doesn't introduce any > warnings. Done, no warnings. I decided to keep prot_to_real() in its current place though. It's probably going to be useful when we support processing ROMs in i386-coreboot (e.g. for biosdisk or vbe). > I'm attaching the script I'm using to test all platforms at once. The > compiler path needs to be adjusted, as well as the target names, as they > affect search for the target compiler. That's the version with qemu > support. If every Log2make is empty, please go ahead. Thanks. Btw, maybe you find this useful: -MAKE_JOBS=8 +MAKE_JOBS=`getconf _NPROCESSORS_ONLN || echo 1` -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."