From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MIhDt-0002zW-0f for mharc-grub-devel@gnu.org; Mon, 22 Jun 2009 06:58:01 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIhDq-0002ys-NN for grub-devel@gnu.org; Mon, 22 Jun 2009 06:57:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIhDl-0002x9-7k for grub-devel@gnu.org; Mon, 22 Jun 2009 06:57:57 -0400 Received: from [199.232.76.173] (port=54725 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIhDl-0002x6-3p for grub-devel@gnu.org; Mon, 22 Jun 2009 06:57:53 -0400 Received: from aybabtu.com ([69.60.117.155]:33619) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MIhDk-00088p-Ev for grub-devel@gnu.org; Mon, 22 Jun 2009 06:57:52 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MIgAj-0007IU-El for grub-devel@gnu.org; Mon, 22 Jun 2009 11:50:41 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MIhDf-0002jq-GZ for grub-devel@gnu.org; Mon, 22 Jun 2009 12:57:47 +0200 Date: Mon, 22 Jun 2009 12:57:47 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090622105747.GH8969@thorin> References: <20090621181748.GA21152@thorin> <20090621202224.GA25553@thorin> <1245635425.9864.55.camel@mj> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1245635425.9864.55.camel@mj> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: [PATCH] i386-qemu port X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2009 10:57:59 -0000 On Sun, Jun 21, 2009 at 09:50:25PM -0400, Pavel Roskin wrote: > On Sun, 2009-06-21 at 22:22 +0200, Robert Millan wrote: > > New patch, after a bunch of misc cleanup, turning hardcoded numbers into > > macros, improving comments, etc. > > kernel_img_FORMAT is defined but never used. It's used by the build system, see: genmk.rb: $(OBJCOPY) -O $(#{prefix}_FORMAT) --strip-unneeded -R .note -R .comment -R .note.gnu.build-id $< $@ > GRUB_MEMORY_MACHINE_LINK_ADDR doesn't need to be conditional, it's the > same for coreboot and qemu. Ok. > Renaming kernel.elf to kernel.img could be done separately. Since it's > a trivial patch, it can be committed without review provided that is > compiles. Committed already. > Please don't add trailing whitespace. Fixed. > Here's my fix for compile warnings and errors. Please incorporate. Merged, thanks. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."