[Bug 13399] kernel crash SONY DVD-ROM with cd

[bugzilla-daemon@bugzilla.kernel.org]

http://bugzilla.kernel.org/show_bug.cgi?id=13399





--- Comment #43 from Borislav Petkov <bbpetkov@yahoo.de>  2009-06-22 15:49:03 ---
(In reply to comment #42)
> Please explain how to apply patch. I downloaded
> 0001-ide-cd-prevent-null-pointer-deref-via-cdrom_newpc_in.patch & saved
> existing linux-2.6.30 to linux-2.6.30-orig but now what? 
> 
> Also, I noted that your patch-ide-cd/diff-attachment.cgi.html shows lines
> 667-673 are to be changed in the ide-cd.c file, ..but my kernel-2.6.30 ide-cd.c
> file has that data on lines 758-764. Will that make the patch fail?
> 
> I have attached a snapshot1.png file showing my kernel-2.6.30 ide-cd.c file.
> 
> Sorry, but I know very little about applying patches. I do have the
> /usr/bin/patch program though if that is what's needed.

Ah, let's do the thing by foot then since it is easier:

Open drivers/ide/ide-cd.c and locate the following lines (as you've done
already in the screenshot):

756                 } else {
757                         if (uptodate <= 0 && rq->errors == 0)
758                                 rq->errors = -EIO;
759                 }
760
761                 if (uptodate == 0)
762                         ide_cd_error_cmd(drive, cmd);
763
764                 /* make sure it's fully ended */

and change the 761th line from

761                 if (uptodate == 0)

to

761                 if (uptodate == 0 && rq->bio)

and then recompile and install your kernel as you normally do. Then boot
test it to see whether it works. That's it :).

Thanks,
Boris.

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.