From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MIntv-0001so-JW for mharc-grub-devel@gnu.org; Mon, 22 Jun 2009 14:05:51 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIntt-0001rt-6a for grub-devel@gnu.org; Mon, 22 Jun 2009 14:05:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MInto-0001pt-72 for grub-devel@gnu.org; Mon, 22 Jun 2009 14:05:48 -0400 Received: from [199.232.76.173] (port=41093 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIntn-0001pp-TC for grub-devel@gnu.org; Mon, 22 Jun 2009 14:05:43 -0400 Received: from aybabtu.com ([69.60.117.155]:48518) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MIntn-0004md-Ak for grub-devel@gnu.org; Mon, 22 Jun 2009 14:05:43 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MImqn-0006xV-3F for grub-devel@gnu.org; Mon, 22 Jun 2009 18:58:33 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MIntk-0002qm-O9 for grub-devel@gnu.org; Mon, 22 Jun 2009 20:05:40 +0200 Date: Mon, 22 Jun 2009 20:05:40 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090622180540.GA29372@thorin> References: <20090621181748.GA21152@thorin> <20090621185444.GA21590@thorin> <1245611156.4250.11.camel@mj> <20090621192555.GB21827@thorin> <1245636853.9864.74.camel@mj> <20090622101056.GD8969@thorin> <1245687395.26471.21.camel@mj> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1245687395.26471.21.camel@mj> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: [PATCH] move grub_stop() (Re: [PATCH] i386-qemu port) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2009 18:05:49 -0000 On Mon, Jun 22, 2009 at 12:16:35PM -0400, Pavel Roskin wrote: > On Mon, 2009-06-22 at 12:10 +0200, Robert Millan wrote: > > > My aim was to move this to C code so it can be shared between i386-qemu > > and i386-coreboot. However, this code will be the same on other i386 > > ports, but we don't yet have a generic .S file for i386 code. > > > > How about kern/i386/misc.S ? > > Fine with me. We shouldn't switch to inferior C code just because we > don't have a shared .S file. Agreed. I just replaced the 3 instances we had of grub_stop() with a single one in kern/i386/misc.S. > Anyway, I think grub_halt() should be renamed to grub_poweroff() to be > more explicit about its goal. Fine with me. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."