From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MIqKQ-0002PE-NG for mharc-grub-devel@gnu.org; Mon, 22 Jun 2009 16:41:22 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIqKO-0002OS-Tz for grub-devel@gnu.org; Mon, 22 Jun 2009 16:41:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIqKK-0002Lv-8D for grub-devel@gnu.org; Mon, 22 Jun 2009 16:41:20 -0400 Received: from [199.232.76.173] (port=45956 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIqKJ-0002Lj-Qx for grub-devel@gnu.org; Mon, 22 Jun 2009 16:41:15 -0400 Received: from aybabtu.com ([69.60.117.155]:60975) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MIqKJ-00075y-DN for grub-devel@gnu.org; Mon, 22 Jun 2009 16:41:15 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MIpHH-00086F-5G for grub-devel@gnu.org; Mon, 22 Jun 2009 21:34:03 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MIqKF-00027K-BP for grub-devel@gnu.org; Mon, 22 Jun 2009 22:41:11 +0200 Date: Mon, 22 Jun 2009 22:41:11 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090622204111.GA7871@thorin> References: <20090621181748.GA21152@thorin> <20090621185009.GB21495@thorin> <1245611299.4250.13.camel@mj> <20090621193333.GD21827@thorin> <20090622123135.GA29332@thorin> <1245699797.2561.4.camel@mj> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1245699797.2561.4.camel@mj> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: [PATCH] define GRUB_MOD_ALIGN to 0 on non-ieee1275 (Re: does module area require alignment? (Re: [PATCH] i386-qemu port)) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2009 20:41:21 -0000 On Mon, Jun 22, 2009 at 03:43:17PM -0400, Pavel Roskin wrote: > On Mon, 2009-06-22 at 14:31 +0200, Robert Millan wrote: > > Well it seems that OLPC (i386-ieee1275) needs alignment, but coreboot doesn't. > > It must be some OFW-specific oddity. > > > > This patch makes the alignment ieee1275-specific on i386. > > We can define GRUB_MOD_ALIGN to 1 for such architectures and keep using > ALIGN_UP (or remove ALIGN_UP - it doesn't matter). The value of 0 for > GRUB_MOD_ALIGN is meaningless, but the value of 1 has a meaning - align > to a byte boundary. Good idea, I just did that. I didn't remove ALIGN_UP, since it's harmless. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."