From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MIs3Q-0006k7-GO for mharc-grub-devel@gnu.org; Mon, 22 Jun 2009 18:31:56 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIs3N-0006hM-Bf for grub-devel@gnu.org; Mon, 22 Jun 2009 18:31:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIs3H-0006bZ-Ru for grub-devel@gnu.org; Mon, 22 Jun 2009 18:31:53 -0400 Received: from [199.232.76.173] (port=33982 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIs3H-0006bW-NT for grub-devel@gnu.org; Mon, 22 Jun 2009 18:31:47 -0400 Received: from aybabtu.com ([69.60.117.155]:51840) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MIs3H-0000DQ-Dl for grub-devel@gnu.org; Mon, 22 Jun 2009 18:31:47 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MIr0F-0001P0-UC for grub-devel@gnu.org; Mon, 22 Jun 2009 23:24:36 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MIs3E-00037h-N7 for grub-devel@gnu.org; Tue, 23 Jun 2009 00:31:44 +0200 Date: Tue, 23 Jun 2009 00:31:44 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090622223144.GA11998@thorin> References: <20090621181748.GA21152@thorin> <20090621185009.GB21495@thorin> <1245611299.4250.13.camel@mj> <20090621193333.GD21827@thorin> <20090622123135.GA29332@thorin> <1245699797.2561.4.camel@mj> <20090622204111.GA7871@thorin> <1245703903.9815.18.camel@mj> <20090622212242.GA10027@thorin> <1245707154.5069.3.camel@mj> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1245707154.5069.3.camel@mj> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: [PATCH] define GRUB_MOD_ALIGN to 0 on non-ieee1275 (Re: does module area require alignment? (Re: [PATCH] i386-qemu port)) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2009 22:31:54 -0000 On Mon, Jun 22, 2009 at 05:45:54PM -0400, Pavel Roskin wrote: > On Mon, 2009-06-22 at 23:22 +0200, Robert Millan wrote: > > On Mon, Jun 22, 2009 at 04:51:43PM -0400, Pavel Roskin wrote: > > > > > > You may want to use 4 byte alignment too. It's a good thing to align > > > 32-bit addresses in the ELF headers. > > > > Ok, but we aren't doing it on i386-pc, and this never caused trouble. The > > ELF headers in our modules are only loaded by GRUB itself, and if our > > loader can cope with unaligned addresses, why bother trying to align > > them? > > Maybe to speed up things. But I don't really care. Well, if there's interest in doing this, I would suggest finding a platform-independant way. For example the modinfo structure could remain unaligned, with padding in-between its ELF modules or so. If there's a speed improvement I'm fine with it. But I can sleep at night without alignment :-) -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."