From: Ingo Molnar <mingo@elte.hu>
To: akpm@linux-foundation.org
Cc: mm-commits@vger.kernel.org, hidave.darkstar@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: + printk-boot_delay-rename-printk_delay_msec-to-loops_per_msec.patch added to -mm tree
Date: Tue, 23 Jun 2009 09:21:16 +0200 [thread overview]
Message-ID: <20090623072116.GC5747@elte.hu> (raw)
In-Reply-To: <200906230556.n5N5uG3a017246@imap1.linux-foundation.org>
> +++ a/kernel/printk.c
> @@ -198,12 +198,11 @@ __setup("log_buf_len=", log_buf_len_setu
> #ifdef CONFIG_BOOT_PRINTK_DELAY
>
> static unsigned int boot_delay; /* msecs delay after each printk during bootup */
> -static unsigned long long printk_delay_msec; /* per msec, based on boot_delay */
> +static unsigned long long loops_per_msec;
Lost a comment here - on purpose?
> - printk_delay_msec = loops_per_msec;
> printk(KERN_DEBUG "boot_delay: %u, preset_lpj: %ld, lpj: %lu, "
> - "HZ: %d, printk_delay_msec: %llu\n",
> - boot_delay, preset_lpj, lpj, HZ, printk_delay_msec);
> + "HZ: %d, loops_per_msec: %llu\n",
> + boot_delay, preset_lpj, lpj, HZ, loops_per_msec);
If you touch debug printks then please use pr_debug().
Ingo
next prev parent reply other threads:[~2009-06-23 7:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 5:56 + printk-boot_delay-rename-printk_delay_msec-to-loops_per_msec.patch added to -mm tree akpm
2009-06-23 7:18 ` Ingo Molnar
2009-06-23 7:21 ` Ingo Molnar [this message]
2009-06-23 12:53 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090623072116.GC5747@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.