Re: [PATCH]Change default network schema in network-bridge

["Daniel P. Berrange" <berrange@redhat.com>]

On Tue, Jun 23, 2009 at 01:07:24PM +0800, Zhigang Wang wrote:
> hi,
> 
> the default network-bridge renames network interfaces and often confuse people.
> 
> this patch changes the network-bridge schema to:
> 
> # start:
> # Creates the bridge
> # Copies the IP and MAC addresses from netdev to bridge
> # Enslaves netdev to bridge
> #
> # stop:
> # Removes netdev from the bridge
> # Transfers addresses, routes from bridge to netdev
> # Deletes bridge
> 
> No rename will be performed.  Eg.
> 
> # brctl show
> bridge name     bridge id               STP enabled     interfaces
> xenbr0          8000.000e0cd85dfe       no              eth0
> 
> IP/route will be transfered to xenbr0 at start.
> 
> I also add a extra script network-bridges to perform on all ethernet cards.
> and network-dummy if user doesn't want to xend to manage dom0 networking.
> 
> This patch obsolete my last patch, titled: [PATCH]Fix network-bridge ifup problem.
> 
> CC to Daniel for comments.



I agree with your thought that it makes more sense to just leave the 
original device name alone, and not rename anything. The reason it
currently does renaming is that this was closer to the previous version
of network-bridge using netloop, and so made upgrades slightly easier
for existing Xen users. 

I don't really have a strong opinion on whether network-bridge should  now 
be changed again to not do renaming of eth0. These days my recommendation
is for people to set '(network-script /bin/true)' and then just use their 
OS distributions network scripts to add a bridge device.  The end result 
is the same, but this has the advantage that the  network is setup correctly
right from start, rather than having to modify it on the fly when apps may 
already have started using the network. We've got docs for Fedora/RHEL/
Debian/Ubuntu here

http://wiki.libvirt.org/page/Networking#Bridged_networking_.28aka_.22shared_physical_device.22.29

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|