From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Date: Tue, 23 Jun 2009 10:02:56 +0000 Subject: Re: [lm-sensors] [PATCH 2/5] sensord: Convert CGI script to lower Message-Id: <20090623120256.6aa06000@hyperion.delvare> List-Id: References: <20090615074755.GF4667@ubuntu> In-Reply-To: <20090615074755.GF4667@ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: lm-sensors@vger.kernel.org On Mon, 15 Jun 2009 09:47:55 +0200, Andre Prendel wrote: > This patch converts HTML code in the generated CGI script to lower > case. This makes us a bit more XHTML compatible. > --- > > rrd.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > Index: sensors/prog/sensord/rrd.c > =================================> --- sensors.orig/prog/sensord/rrd.c 2009-06-09 20:31:13.000000000 +0200 > +++ sensors/prog/sensord/rrd.c 2009-06-09 22:05:04.000000000 +0200 > @@ -449,16 +449,16 @@ > { > int ret = 0, i; > > - printf("#!" RRDCGI "\n\n\n" > - "\nsensord\n\n" > - "\n

sensord

\n"); > + printf("#!" RRDCGI "\n\n\n" > + "\nsensord\n\n" > + "\n

sensord

\n"); > > for (i = 0; i < ARRAY_SIZE(graphs); i++) { > struct gr *graph = &graphs[i]; > > - printf("

%s

\n", graph->h2); > - printf("

\n - "'" > + printf("

%s

\n", graph->h2); > + printf("

\n + "'" Not sure why you didn't lowercase IMG, WIDTH and HEIGHT here? > "\n\t-a PNG\n\t-h 200 -w 800\n", > sensord_args.cgiDir, graph->image); > > @@ -473,7 +473,7 @@ > ret = applyToFeatures(rrdCGI_LINE, graph); > if (!ret && sensord_args.doLoad && graph->loadAvg) > ret = rrdCGI_LINE(graph, LOADAVG, LOAD_AVERAGE, NULL); > - printf (">\n

\n"); > + printf (">\n

\n"); > } > printf("

\nsensord by " > "Merlin Hughes" > @@ -481,7 +481,7 @@ > "lm_sensors " > "crew.\n

\n"); > > - printf("\n\n"); > + printf("\n\n"); > > return ret; > } Otherwise it looks good. -- Jean Delvare _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors