From: Arnd Bergmann <arnd@arndb.de>
To: Andi Kleen <andi@firstfloor.org>
Cc: liqin.chen@sunplusct.com,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: S+core architecture (arch/score/) support files
Date: Tue, 23 Jun 2009 15:55:54 +0200 [thread overview]
Message-ID: <200906231555.54887.arnd@arndb.de> (raw)
In-Reply-To: <87zlbz17fb.fsf@basil.nowhere.org>
On Tuesday 23 June 2009, Andi Kleen wrote:
> IMHO a full successfull LTP run should be minimal criterium for
> merging an architecture. That should catch most of the possible
> "simple" mistakes in the syscall ABI. I would suggest to wait to after
> this has been done.
I agree in general, but in this case the ABI is essentially defined
through the asm-generic headers, with the exception of the functions
that actually were tested before the change (sys_clone, sys_execve,
sys_rt_sigreturn and sys_sig).
We should certainly fix the asm-generic versions if there are some
unexpected problems found by LTP, but delaying the score merge
won't help that, because the interesting code is already there.
While I understand the argument against merging untested code
(that's why I mentioned it in the first place), I think in
this case it's not about the ABI and the code is obviously
self-contained enough to cause no harm to others.
Arnd <><
next prev parent reply other threads:[~2009-06-23 13:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 8:37 S+core architecture (arch/score/) support files liqin.chen
2009-06-23 9:43 ` Arnd Bergmann
2009-06-23 10:51 ` liqin.chen
2009-06-23 10:51 ` liqin.chen
2009-06-23 12:06 ` Andi Kleen
2009-06-23 13:55 ` Arnd Bergmann [this message]
2009-06-23 14:30 ` Andi Kleen
2009-06-24 3:22 ` liqin.chen
2009-06-24 3:22 ` liqin.chen
2009-06-24 7:07 ` Andi Kleen
2009-06-25 3:00 ` liqin.chen
2009-06-25 3:00 ` liqin.chen
2009-06-23 14:50 ` Christoph Hellwig
2009-07-08 10:53 ` [PATCH] score: add regsets support for score liqin.chen
2009-07-09 15:08 ` Arnd Bergmann
2009-07-09 21:03 ` Roland McGrath
2009-07-10 9:06 ` liqin.chen
2009-07-10 9:06 ` liqin.chen
2009-07-10 9:43 ` liqin.chen
2009-07-10 9:43 ` liqin.chen
2009-07-10 10:44 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906231555.54887.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=andi@firstfloor.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liqin.chen@sunplusct.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.