From: Oleg Nesterov <oleg@redhat.com>
To: Scott James Remnant <scott@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Matt Helsley <matthltc@us.ibm.com>, linux-kernel@vger.kernel.org
Subject: Re: + proc-connector-add-event-for-process-becoming-session-leader.patch added to -mm tree
Date: Tue, 23 Jun 2009 22:29:37 +0200 [thread overview]
Message-ID: <20090623202937.GA31252@redhat.com> (raw)
> The act of a process becoming a session leader is a useful signal to a
> supervising init daemon such as Upstart.
...
> @@ -360,8 +360,10 @@ void __set_special_pids(struct pid *pid)
> {
> struct task_struct *curr = current->group_leader;
>
> - if (task_session(curr) != pid)
> + if (task_session(curr) != pid) {
> change_pid(curr, PIDTYPE_SID, pid);
> + proc_sid_connector(curr);
> + }
Wouldn't it better to change sys_setsid() then? This looks more clear
imho, and we can move proc_sid_connector() outside of tasklist_lock.
Note also that __set_special_pids() does not neccessary mean we are
becoming a session leader, see daemonize().
Oleg.
next reply other threads:[~2009-06-23 23:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 20:29 Oleg Nesterov [this message]
2009-06-24 8:53 ` + proc-connector-add-event-for-process-becoming-session-leader.patch added to -mm tree Scott James Remnant
2009-06-24 14:44 ` Oleg Nesterov
-- strict thread matches above, loose matches on Subject: below --
2009-06-22 23:19 akpm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090623202937.GA31252@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
--cc=scott@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.