All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gerhard Pircher" <gerhard_pircher@gmx.net>
To: benh@kernel.crashing.org, tiwai@suse.de
Cc: linuxppc-dev@ozlabs.org
Subject: Re: ALSA fixes for non-coherent ppc32 again
Date: Tue, 23 Jun 2009 23:42:24 +0200	[thread overview]
Message-ID: <20090623214224.104620@gmx.net> (raw)
In-Reply-To: <20090623085554.9200@gmx.net>


-------- Original-Nachricht --------
> Datum: Tue, 23 Jun 2009 10:55:54 +0200
> Von: "Gerhard Pircher" <gerhard_pircher@gmx.net>
> An: Takashi Iwai <tiwai@suse.de>, benh@kernel.crashing.org
> CC: linuxppc-dev@ozlabs.org
> Betreff: Re: ALSA fixes for non-coherent ppc32 again

> 
> -------- Original-Nachricht --------
> > Datum: Mon, 22 Jun 2009 09:12:35 +0200
> > Von: Takashi Iwai <tiwai@suse.de>
> > An: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > CC: Gerhard Pircher <gerhard_pircher@gmx.net>, linuxppc-dev@ozlabs.org
> > Betreff: Re: ALSA fixes for non-coherent ppc32 again
> 
> > But, it'd be helpful if someone can test the patches above beforehand,
> > of course :)
> Okay, I checked out your test/dma-fix branch and reformatted your
> dma_mmap_coherent for powerpc patch (
> http://www.nabble.com/-PATCH-0-3--ALSA-fixes-for-non-coherent-ppc32-to17980027.html#a17980027 ) to
> adapt it for dma_mapping_ops (please take a look at the patch below).
> I also had to change "def_bool n" to "def_bool y" for SND_NONCOHERENT_DMA
> to actually enable it.
> 
> Unfortunately the build process stops with these error messages here
> (but compiles fine, if SND_COHERENT_DMA is not selected):
> 
>   CC [M]  sound/core/memalloc.o
>   CC [M]  sound/core/sgbuf.o
> sound/core/sgbuf.c: In function ‘snd_free_sgbuf_pages’:
> sound/core/sgbuf.c:46: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:47: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:48: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:50: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:51: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:52: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:56: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:57: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c: In function ‘snd_malloc_sgbuf_pages’:
> sound/core/sgbuf.c:78: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:81: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:82: error: implicit declaration of function
> ‘snd_sgbuf_aligned_pages’
> sound/core/sgbuf.c:83: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:84: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:84: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:87: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:88: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:91: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:103: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:107: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:112: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:113: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:115: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:116: error: increment of pointer to unknown structure
> sound/core/sgbuf.c:116: error: arithmetic on pointer to an incomplete type
> sound/core/sgbuf.c:121: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:127: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:128: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:128: error: dereferencing pointer to incomplete type
> sound/core/sgbuf.c:132: error: dereferencing pointer to incomplete type
> 
> I also tried to compile it with the orginal dma_mmap_coherent for
> powerpc patch, but that doesn't make a difference.
> 
> As the next step I applied the reformatted dma_mmap_coherent patch and
> the following patches from your test/dma-fix branch to a 2.6.30-rc8
> branch:
> - ALSA: Remove old DMA-mmap code from arm/devdma.c
> - ALSA: Fix SG-buffer DMA with non-coherent architectures
> - ALSA: Fix mapping of DMA buffers
> 
> This one compiled fine, but ALSA didn't work. No kernel oops, just the
> sound of silence. :)
Okay, that's wrong. I somehow messed up the .config file. It doesn't
compile, too.

Gerhard

-- 
GRATIS für alle GMX-Mitglieder: Die maxdome Movie-FLAT!
Jetzt freischalten unter http://portal.gmx.net/de/go/maxdome01

  reply	other threads:[~2009-06-23 21:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-21 18:18 ALSA fixes for non-coherent ppc32 again Gerhard Pircher
2009-06-21 22:34 ` Benjamin Herrenschmidt
2009-06-22  7:12   ` Takashi Iwai
2009-06-22  9:23     ` Gerhard Pircher
2009-06-23  8:55     ` Gerhard Pircher
2009-06-23 21:42       ` Gerhard Pircher [this message]
2009-06-24  8:46         ` Gerhard Pircher
2009-06-24  9:47           ` Takashi Iwai
2009-06-26 13:14             ` Gerhard Pircher
2009-07-08 14:14               ` Takashi Iwai
2009-07-08  3:01   ` Benjamin Herrenschmidt
2009-07-08 14:13     ` Takashi Iwai
2009-07-09 11:22       ` Gerhard Pircher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090623214224.104620@gmx.net \
    --to=gerhard_pircher@gmx.net \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.