From: Frans Pop <elendil@planet.nl>
To: David Miller <davem@davemloft.net>
Cc: bzolnier@gmail.com, sparclinux@vger.kernel.org,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ide-cd: Improve "weird block size" error message
Date: Tue, 23 Jun 2009 23:30:18 +0200 [thread overview]
Message-ID: <200906232330.20519.elendil@planet.nl> (raw)
In-Reply-To: <20090623.035926.155211513.davem@davemloft.net>
On Tuesday 23 June 2009, David Miller wrote:
> ide-cd: Don't warn on bogus block size unless it actually matters.
>
> Frans Pop reported that his CDROM drive reports a blocksize of 2352,
> and this causes new warnings due to commit
> e8e7b9eb11c34ee18bde8b7011af41938d1ad667 ("ide-cd: fix oops when using
> growisofs").
>
> What we're trying to do is make sure that "blocklen >> SECTOR_BITS"
> is something the block layer won't choke on.
>
> And for Frans case "2352 >> SECTOR_BITS" is equal to
> "2048 >> SECTOR_BITS", and thats "4".
Pedantic correction: Frans' case
> So warning in this case gives no real benefit.
>
> Reported-by: Frans Pop <elendil@planet.nl>
> Signed-off-by: David S. Miller <davem@davemloft.net>
As expected, it's gone. Nice.
Tested-by: Frans Pop <elendil@planet.nl>
next prev parent reply other threads:[~2009-06-23 21:30 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-20 21:52 cmd64x: irq 14: nobody cared - system is dreadfully slow Frans Pop
2009-06-21 0:19 ` David Miller
2009-06-21 4:47 ` Frans Pop
2009-06-21 12:46 ` Frans Pop
2009-06-21 13:33 ` Bartlomiej Zolnierkiewicz
2009-06-21 20:14 ` Frans Pop
2009-06-22 1:56 ` David Miller
2009-06-22 4:28 ` Frans Pop
2009-06-22 5:45 ` David Miller
2009-06-22 6:43 ` Frans Pop
2009-06-22 6:44 ` David Miller
2009-06-22 11:21 ` Bartlomiej Zolnierkiewicz
2009-06-22 14:04 ` Frans Pop
2009-06-22 14:39 ` Bartlomiej Zolnierkiewicz
2009-06-22 15:16 ` Frans Pop
2009-06-22 17:38 ` Bartlomiej Zolnierkiewicz
2009-06-22 19:01 ` Frans Pop
2009-06-22 21:35 ` Bartlomiej Zolnierkiewicz
2009-06-23 7:51 ` [PATCH] ide-cd: Improve "weird block size" error message Frans Pop
2009-06-23 7:57 ` Borislav Petkov
2009-06-23 8:02 ` Borislav Petkov
2009-06-23 23:03 ` David Miller
2009-06-23 8:20 ` Frans Pop
2009-06-23 10:59 ` David Miller
2009-06-23 11:13 ` Frans Pop
2009-06-23 11:18 ` David Miller
2009-06-23 21:30 ` Frans Pop [this message]
2009-06-23 23:01 ` David Miller
2009-06-29 11:19 ` Jan Engelhardt
2009-06-23 10:15 ` cmd64x: irq 14: nobody cared - system is dreadfully slow David Miller
2009-06-23 14:58 ` Frans Pop
2009-06-23 16:13 ` Bartlomiej Zolnierkiewicz
2009-06-23 23:04 ` David Miller
2009-06-23 10:47 ` David Miller
2009-06-23 10:43 ` David Miller
2009-07-31 14:08 ` Frans Pop
2009-07-31 14:08 ` Frans Pop
2009-08-01 5:46 ` David Miller
2009-08-01 5:46 ` David Miller
2009-08-05 20:43 ` [stable] " Greg KH
2009-08-05 20:43 ` [stable] cmd64x: irq 14: nobody cared - system is dreadfully Greg KH
2009-06-21 13:15 ` cmd64x: irq 14: nobody cared - system is dreadfully slow Bartlomiej Zolnierkiewicz
2009-06-21 21:19 ` David Miller
2009-06-21 22:34 ` Bartlomiej Zolnierkiewicz
2009-06-21 22:57 ` David Miller
2009-06-21 23:13 ` New IDE maintainer (was Re: cmd64x: irq 14: nobody cared - system is dreadfully slow) David Miller
2009-06-21 23:45 ` Bartlomiej Zolnierkiewicz
2009-06-21 23:52 ` New IDE maintainer David Miller
2009-06-22 0:53 ` New IDE maintainer (was Re: cmd64x: irq 14: nobody cared - system is dreadfully slow) Matthew Wilcox
2009-06-22 0:00 ` Stephen Rothwell
2009-06-22 0:20 ` New IDE maintainer David Miller
2009-06-22 3:39 ` New IDE maintainer (was Re: cmd64x: irq 14: nobody cared - system is dreadfully slow) Greg Freemyer
2009-06-22 3:39 ` Greg Freemyer
2009-06-22 17:03 ` Jeff Garzik
2009-06-22 17:11 ` Alan Cox
2009-06-22 17:21 ` Arnd Bergmann
2009-06-22 17:21 ` Arnd Bergmann
2009-06-22 17:32 ` Alan Cox
2009-06-22 3:47 ` cmd64x: irq 14: nobody cared - system is dreadfully slow Frans Pop
2009-06-21 15:43 ` Bartlomiej Zolnierkiewicz
2009-06-21 21:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906232330.20519.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=bzolnier@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.