All of lore.kernel.org
 help / color / mirror / Atom feed
From: Magnus Damm <magnus.damm@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: gregkh@suse.de, ben-linux@fluff.org, hskinnemoen@atmel.com,
	anemo@mba.ocn.ne.jp, linux-usb@vger.kernel.org,
	Magnus Damm <magnus.damm@gmail.com>,
	rjw@sisk.pl, stern@rowland.harvard.edu, pavel@ucw.cz,
	linux-pm@lists.linux-foundation.org, linux-omap@vger.kernel.org,
	akpm@linux-foundation.org, felipe.balbi@nokia.com
Subject: [PATCH 05/07] i2c: rework i2c-s3c2410 suspend_late()/resume() V2
Date: Wed, 24 Jun 2009 18:23:50 +0900	[thread overview]
Message-ID: <20090624092350.14276.82072.sendpatchset@rx1.opensource.se> (raw)
In-Reply-To: <20090624092306.14276.127.sendpatchset@rx1.opensource.se>

From: Magnus Damm <damm@igel.co.jp>

This is V2 of the i2c-s3c2410 dev_pm_ops patch.

The callbacks are converted for CONFIG_SUSPEND like this:
  suspend_late() -> suspend_noirq()
  resume() -> resume()

Signed-off-by: Magnus Damm <damm@igel.co.jp>
---

 Changes since V1:
 - resolved conflicts to fit upstream changes

 drivers/i2c/busses/i2c-s3c2410.c |   25 ++++++++++++++++---------
 1 file changed, 16 insertions(+), 9 deletions(-)

--- 0001/drivers/i2c/busses/i2c-s3c2410.c
+++ work/drivers/i2c/busses/i2c-s3c2410.c	2009-06-22 17:18:22.000000000 +0900
@@ -951,17 +951,20 @@ static int s3c24xx_i2c_remove(struct pla
 }
 
 #ifdef CONFIG_PM
-static int s3c24xx_i2c_suspend_late(struct platform_device *dev,
-				    pm_message_t msg)
+static int s3c24xx_i2c_suspend_noirq(struct device *dev)
 {
-	struct s3c24xx_i2c *i2c = platform_get_drvdata(dev);
+	struct platform_device *pdev = to_platform_device(dev);
+	struct s3c24xx_i2c *i2c = platform_get_drvdata(pdev);
+
 	i2c->suspended = 1;
+
 	return 0;
 }
 
-static int s3c24xx_i2c_resume(struct platform_device *dev)
+static int s3c24xx_i2c_resume(struct device *dev)
 {
-	struct s3c24xx_i2c *i2c = platform_get_drvdata(dev);
+	struct platform_device *pdev = to_platform_device(dev);
+	struct s3c24xx_i2c *i2c = platform_get_drvdata(pdev);
 
 	i2c->suspended = 0;
 	s3c24xx_i2c_init(i2c);
@@ -969,9 +972,14 @@ static int s3c24xx_i2c_resume(struct pla
 	return 0;
 }
 
+static struct dev_pm_ops s3c24xx_i2c_dev_pm_ops = {
+	.suspend_noirq = s3c24xx_i2c_suspend_noirq,
+	.resume = s3c24xx_i2c_resume,
+};
+
+#define S3C24XX_DEV_PM_OPS (&s3c24xx_i2c_dev_pm_ops)
 #else
-#define s3c24xx_i2c_suspend_late NULL
-#define s3c24xx_i2c_resume NULL
+#define S3C24XX_DEV_PM_OPS NULL
 #endif
 
 /* device driver for platform bus bits */
@@ -990,12 +998,11 @@ MODULE_DEVICE_TABLE(platform, s3c24xx_dr
 static struct platform_driver s3c24xx_i2c_driver = {
 	.probe		= s3c24xx_i2c_probe,
 	.remove		= s3c24xx_i2c_remove,
-	.suspend_late	= s3c24xx_i2c_suspend_late,
-	.resume		= s3c24xx_i2c_resume,
 	.id_table	= s3c24xx_driver_ids,
 	.driver		= {
 		.owner	= THIS_MODULE,
 		.name	= "s3c-i2c",
+		.pm	= S3C24XX_DEV_PM_OPS,
 	},
 };
 

  parent reply	other threads:[~2009-06-24  9:23 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-24  9:23 [PATCH 00/07] pm: remove late/early platform driver pm callbacks V2 Magnus Damm
2009-06-24  9:23 ` Magnus Damm
2009-06-24  9:23 ` [PATCH 01/07] arm: rework omap suspend_late()/resume_early() Magnus Damm
2009-06-24  9:23   ` Magnus Damm
2009-06-24  9:23 ` [PATCH 02/07] dma: rework dw_dmac suspend_late()/resume_early() Magnus Damm
2009-06-24  9:23   ` Magnus Damm
2009-06-24  9:23 ` [PATCH 03/07] dma: rework txx9dmac suspend_late()/resume_early() Magnus Damm
2009-06-24  9:23 ` [PATCH 04/07] i2c: rework i2c-pxa suspend_late()/resume_early() Magnus Damm
     [not found] ` <20090624092306.14276.127.sendpatchset-/W6D1AVitZKvog7CDwlRTrNAH6kLmebB@public.gmane.org>
2009-06-24  9:23   ` [PATCH 03/07] dma: rework txx9dmac suspend_late()/resume_early() Magnus Damm
2009-06-24  9:23     ` Magnus Damm
2009-06-24  9:23   ` [PATCH 04/07] i2c: rework i2c-pxa suspend_late()/resume_early() Magnus Damm
2009-06-24  9:23     ` Magnus Damm
2009-06-24  9:24   ` [PATCH 06/07] usb: rework musb suspend()/resume_early() Magnus Damm
2009-06-24  9:24     ` Magnus Damm
2009-06-24 20:34     ` Greg KH
2009-06-24 20:34     ` Greg KH
2009-06-24 18:48   ` [PATCH 00/07] pm: remove late/early platform driver pm callbacks V2 Rafael J. Wysocki
2009-06-24 18:48     ` Rafael J. Wysocki
2009-06-24 18:56     ` Pavel Machek
2009-06-24 18:56     ` Pavel Machek
2009-06-24 20:33     ` Greg KH
     [not found]     ` <200906242048.40956.rjw-KKrjLPT3xs0@public.gmane.org>
2009-06-24 20:33       ` Greg KH
2009-06-24 20:33         ` Greg KH
2009-06-24  9:23 ` Magnus Damm [this message]
2009-06-24  9:23 ` [PATCH 05/07] i2c: rework i2c-s3c2410 suspend_late()/resume() V2 Magnus Damm
2009-06-24  9:24 ` [PATCH 06/07] usb: rework musb suspend()/resume_early() Magnus Damm
2009-06-24  9:24 ` [PATCH 07/07] pm: remove platform device suspend_late()/resume_early() V2 Magnus Damm
2009-06-24 16:02   ` Pavel Machek
2009-06-24 16:02   ` Pavel Machek
2009-06-24  9:24 ` Magnus Damm
2009-06-24 18:48 ` [PATCH 00/07] pm: remove late/early platform driver pm callbacks V2 Rafael J. Wysocki
2009-07-04 23:45 ` Rafael J. Wysocki
2009-07-04 23:45 ` Rafael J. Wysocki
2009-09-09  1:25   ` Dan Williams
2009-09-09  1:25   ` Dan Williams
2009-09-09  1:25     ` Dan Williams
2009-09-09 22:09     ` Rafael J. Wysocki
2009-09-09 22:09     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090624092350.14276.82072.sendpatchset@rx1.opensource.se \
    --to=magnus.damm@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=ben-linux@fluff.org \
    --cc=felipe.balbi@nokia.com \
    --cc=gregkh@suse.de \
    --cc=hskinnemoen@atmel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.