From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MJRKs-0003mr-8n for mharc-grub-devel@gnu.org; Wed, 24 Jun 2009 08:12:18 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJRKp-0003kq-Io for grub-devel@gnu.org; Wed, 24 Jun 2009 08:12:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJRKk-0003jp-Ka for grub-devel@gnu.org; Wed, 24 Jun 2009 08:12:15 -0400 Received: from [199.232.76.173] (port=49943 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJRKk-0003jO-GA for grub-devel@gnu.org; Wed, 24 Jun 2009 08:12:10 -0400 Received: from aybabtu.com ([69.60.117.155]:57634) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MJRKj-0001WV-37 for grub-devel@gnu.org; Wed, 24 Jun 2009 08:12:09 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MJQHS-0004Gj-6M for grub-devel@gnu.org; Wed, 24 Jun 2009 13:04:42 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MJRKZ-0000OQ-T9 for grub-devel@gnu.org; Wed, 24 Jun 2009 14:11:59 +0200 Date: Wed, 24 Jun 2009 14:11:59 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090624121159.GC1429@thorin> References: <20090624112049.GU11691@tas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090624112049.GU11691@tas> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: support for crashkernel= in 10_linux.in X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jun 2009 12:12:15 -0000 Hi Michael, On Wed, Jun 24, 2009 at 01:20:49PM +0200, Michael Vogt wrote: > diff -Nur -x '*.orig' -x '*~' grub2-1.96+20090611/util/grub.d/10_linux.in grub2-1.96+20090611.new/util/grub.d/10_linux.in > --- grub2-1.96+20090611/util/grub.d/10_linux.in 2009-06-24 10:17:45.202761012 +0200 > +++ grub2-1.96+20090611.new/util/grub.d/10_linux.in 2009-06-24 10:19:11.198757708 +0200 > @@ -43,6 +43,11 @@ > LINUX_ROOT_DEVICE=UUID=${GRUB_DEVICE_UUID} > fi > > +# add crashkernel option if we have the requierd tools > +if [ -x "/usr/bin/makedumpfile" ] && [ -x "/sbin/kexec" ]; then > + GRUB_CMDLINE_EXTRA="$GRUB_CMDLINE_EXTRA crashkernel=384M-2G:64M,2G-:128M" > +fi > + So many variables start to look confusing. Can't you append it to one of the others? Or give it a more explicit name, like ${GRUB_CMDLINE_LINUX_CRASHADDR} or so (in any case GRUB_CMDLINE_EXTRA is too generic for a Linux-specific thing). > linux_entry "${OS}, Linux ${version}" \ > - "${GRUB_CMDLINE_LINUX} ${GRUB_CMDLINE_LINUX_DEFAULT}" > + "${GRUB_CMDLINE_LINUX} ${GRUB_CMDLINE_LINUX_DEFAULT} ${GRUB_CMDLINE_EXTRA}" > linux_entry "${OS}, Linux ${version} (recovery mode)" \ > "single ${GRUB_CMDLINE_LINUX}" Is this flag not desireable in recovery mode? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."