From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MJSGV-0008Up-HC for mharc-grub-devel@gnu.org; Wed, 24 Jun 2009 09:11:51 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJSGT-0008Tg-Gy for grub-devel@gnu.org; Wed, 24 Jun 2009 09:11:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJSGO-0008Qw-GK for grub-devel@gnu.org; Wed, 24 Jun 2009 09:11:48 -0400 Received: from [199.232.76.173] (port=59347 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJSGO-0008Qo-8U for grub-devel@gnu.org; Wed, 24 Jun 2009 09:11:44 -0400 Received: from out1.smtp.messagingengine.com ([66.111.4.25]:55606) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJSGN-0003V6-Ed for grub-devel@gnu.org; Wed, 24 Jun 2009 09:11:43 -0400 Received: from compute2.internal (compute2.internal [10.202.2.42]) by out1.messagingengine.com (Postfix) with ESMTP id 8578637E385 for ; Wed, 24 Jun 2009 09:11:42 -0400 (EDT) Received: from heartbeat2.messagingengine.com ([10.202.2.161]) by compute2.internal (MEProxy); Wed, 24 Jun 2009 09:11:41 -0400 X-Sasl-enc: QvQtVX5U2ZLlB816JuJrXdZr5uuoAJDrqe9bkfVTWZv9 1245849101 Received: from tas.localdomain (p54A65C9C.dip.t-dialin.net [84.166.92.156]) by www.fastmail.fm (Postfix) with ESMTPSA id 6187E2EC72 for ; Wed, 24 Jun 2009 09:11:41 -0400 (EDT) Received: by tas.localdomain (Postfix, from userid 1000) id 14BAA10E06C1; Wed, 24 Jun 2009 15:11:39 +0200 (CEST) Date: Wed, 24 Jun 2009 15:11:39 +0200 From: Michael Vogt To: The development of GRUB 2 Message-ID: <20090624131139.GV11691@tas> References: <20090624112049.GU11691@tas> <20090624121159.GC1429@thorin> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="7LkOrbQMr4cezO2T" Content-Disposition: inline In-Reply-To: <20090624121159.GC1429@thorin> User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: support for crashkernel= in 10_linux.in X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jun 2009 13:11:49 -0000 --7LkOrbQMr4cezO2T Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 24, 2009 at 02:11:59PM +0200, Robert Millan wrote: > Hi Michael, Hi Robert, Thanks for your quick reply. > On Wed, Jun 24, 2009 at 01:20:49PM +0200, Michael Vogt wrote: > > diff -Nur -x '*.orig' -x '*~' grub2-1.96+20090611/util/grub.d/10_linux.in grub2-1.96+20090611.new/util/grub.d/10_linux.in > > --- grub2-1.96+20090611/util/grub.d/10_linux.in 2009-06-24 10:17:45.202761012 +0200 > > +++ grub2-1.96+20090611.new/util/grub.d/10_linux.in 2009-06-24 10:19:11.198757708 +0200 > > @@ -43,6 +43,11 @@ > > LINUX_ROOT_DEVICE=UUID=${GRUB_DEVICE_UUID} > > fi > > > > +# add crashkernel option if we have the requierd tools > > +if [ -x "/usr/bin/makedumpfile" ] && [ -x "/sbin/kexec" ]; then > > + GRUB_CMDLINE_EXTRA="$GRUB_CMDLINE_EXTRA crashkernel=384M-2G:64M,2G-:128M" > > +fi > > + > > So many variables start to look confusing. Can't you append it to one of > the others? Sure, attached is a updated version that does that. > Or give it a more explicit name, like ${GRUB_CMDLINE_LINUX_CRASHADDR} or so > (in any case GRUB_CMDLINE_EXTRA is too generic for a Linux-specific thing). > > > linux_entry "${OS}, Linux ${version}" \ > > - "${GRUB_CMDLINE_LINUX} ${GRUB_CMDLINE_LINUX_DEFAULT}" > > + "${GRUB_CMDLINE_LINUX} ${GRUB_CMDLINE_LINUX_DEFAULT} ${GRUB_CMDLINE_EXTRA}" > > linux_entry "${OS}, Linux ${version} (recovery mode)" \ > > "single ${GRUB_CMDLINE_LINUX}" > > Is this flag not desireable in recovery mode? Maybe - my rational was to keep recovery mode as simple as possible. And also in case there is a issue with the crashkernel= commandlinethe user is still able to use recovery mode (its pretty unlikely that there are problems though). Cheers, Michael --7LkOrbQMr4cezO2T Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="10_crashkernel2.patch" === modified file 'util/grub.d/10_linux.in' --- util/grub.d/10_linux.in 2009-06-24 13:00:17 +0000 +++ util/grub.d/10_linux.in 2009-06-24 13:09:26 +0000 @@ -35,6 +35,11 @@ ;; esac +# add crashkernel option if we have the requierd tools +if [ -x "/usr/bin/makedumpfile" ] && [ -x "/sbin/kexec" ]; then + GRUB_CMDLINE_LINUX_DEFAULT="$GRUB_CMDLINE_LINUX_DEFAULT crashkernel=384M-2G:64M,2G-:128M" +fi + if [ "x${GRUB_DEVICE_UUID}" = "x" ] || [ "x${GRUB_DISABLE_LINUX_UUID}" = "xtrue" ] \ || ! test -e "/dev/disk/by-uuid/${GRUB_DEVICE_UUID}" ; then LINUX_ROOT_DEVICE=${GRUB_DEVICE} --7LkOrbQMr4cezO2T--