From: Paul Mundt <lethal@linux-sh.org>
To: Greg KH <gregkh@suse.de>
Cc: Daniel Mack <daniel@caiaq.de>,
linux-kernel@vger.kernel.org, hjk@linutronix.de,
magnus.damm@gmail.com
Subject: Re: [PATCH 1/2] UIO: add device clock support
Date: Thu, 25 Jun 2009 03:41:21 +0900 [thread overview]
Message-ID: <20090624184120.GA12953@linux-sh.org> (raw)
In-Reply-To: <20090624163414.GB26409@suse.de>
On Wed, Jun 24, 2009 at 09:34:14AM -0700, Greg KH wrote:
> On Wed, Jun 24, 2009 at 05:30:24PM +0200, Daniel Mack wrote:
> > Add a pointer to a 'struct clk' to uio_info. Drivers can set
> > this pointer if a clock is needed, and the UIO core will care
> > to enable and disable it upon device open and release.
>
> Do you have a UIO driver that needs this?
>
> If so, please submit it at the same time, otherwise adding
> infrastructure for no driver that needs it, is pretty pointless.
>
We can use this for the uio_pdrv_genirq case on sh, but open/release is a
bit coarse grained. Presently we default-enable clocks for devices that
are handled through uio, so doing it at open/release is at least better
than that. The other thing to consider is if we really want to add a
HAVE_CLK depdendency outright, or just ifdef around it..
next prev parent reply other threads:[~2009-06-24 18:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 15:30 Two small UIO patches Daniel Mack
2009-06-24 15:30 ` [PATCH 1/2] UIO: add device clock support Daniel Mack
2009-06-24 15:30 ` [PATCH 2/2] UIO: remove 'default n' from Kconfig Daniel Mack
2009-06-24 16:34 ` Greg KH
2009-06-24 18:32 ` Daniel Mack
2009-06-24 18:32 ` Greg KH
2009-06-24 16:34 ` [PATCH 1/2] UIO: add device clock support Greg KH
2009-06-24 18:29 ` Daniel Mack
2009-06-24 18:32 ` Greg KH
2009-06-24 18:41 ` Paul Mundt [this message]
2009-06-25 15:17 ` Magnus Damm
2009-06-25 17:47 ` Paul Mundt
2009-06-26 8:28 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090624184120.GA12953@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=daniel@caiaq.de \
--cc=gregkh@suse.de \
--cc=hjk@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.