All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
	linux-usb@vger.kernel.org, oliver@neukum.name
Subject: Re: [PATCH 1/3] Return ENODEV instead of EINVAL when trying to open ACM device.
Date: Wed, 24 Jun 2009 13:40:15 -0700	[thread overview]
Message-ID: <20090624204015.GD28516@suse.de> (raw)
In-Reply-To: <1245843077-4442-1-git-send-email-cascardo@holoscopio.com>

On Wed, Jun 24, 2009 at 08:31:15AM -0300, Thadeu Lima de Souza Cascardo wrote:
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
> ---
>  drivers/usb/class/cdc-acm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> index 38bfdb0..02eb60b 100644
> --- a/drivers/usb/class/cdc-acm.c
> +++ b/drivers/usb/class/cdc-acm.c
> @@ -550,7 +550,7 @@ static void acm_waker(struct work_struct *waker)
>  static int acm_tty_open(struct tty_struct *tty, struct file *filp)
>  {
>  	struct acm *acm;
> -	int rv = -EINVAL;
> +	int rv = -ENODEV;

Why is this needed?

thanks,

greg k-h

  parent reply	other threads:[~2009-06-24 20:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-24 11:31 [PATCH 1/3] Return ENODEV instead of EINVAL when trying to open ACM device Thadeu Lima de Souza Cascardo
2009-06-24 11:31 ` [PATCH 2/3] Fix oops when closing ACM tty device right after open has failed Thadeu Lima de Souza Cascardo
2009-06-24 11:31   ` [PATCH 3/3] Fix oops when unexisting usb serial device is opened Thadeu Lima de Souza Cascardo
2009-06-24 20:41     ` Greg KH
2009-06-24 20:41   ` [PATCH 2/3] Fix oops when closing ACM tty device right after open has failed Greg KH
2009-06-24 21:35     ` Thadeu Lima de Souza Cascardo
2009-06-24 21:37       ` Greg KH
2009-06-24 20:40 ` Greg KH [this message]
2009-06-24 21:17   ` [PATCH 1/3] Return ENODEV instead of EINVAL when trying to open ACM device Oliver Neukum
2009-06-24 21:19     ` Thadeu Lima de Souza Cascardo
  -- strict thread matches above, loose matches on Subject: below --
2009-06-24 21:33 Thadeu Lima de Souza Cascardo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090624204015.GD28516@suse.de \
    --to=gregkh@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=cascardo@holoscopio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oliver@neukum.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.