From: Al Viro <viro@ZenIV.linux.org.uk>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Build failure latest git. (acl related)
Date: Wed, 24 Jun 2009 21:49:06 +0100 [thread overview]
Message-ID: <20090624204906.GV8633@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20090624204658.GB31192@phenom2.trippelsdorf.de>
On Wed, Jun 24, 2009 at 10:46:58PM +0200, Markus Trippelsdorf wrote:
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index 78ad38d..1f7aa6c 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -2122,10 +2122,12 @@ static void btrfs_read_locked_inode(struct inode *inode)
> * any xattrs or acls
> */
> maybe_acls = acls_after_inode_item(leaf, path->slots[0], inode->i_ino);
> +#ifdef CONFIG_FS_POSIX_ACL
> if (!maybe_acls) {
> inode->i_acl = NULL;
> inode->i_default_acl = NULL;
> }
> +#endif
Actually, I disagree with that one - it begs for a helper function instead
of ifdef. Give me a few...
next prev parent reply other threads:[~2009-06-24 20:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 20:09 Build failure latest git. (acl related) Markus Trippelsdorf
2009-06-24 20:28 ` Markus Trippelsdorf
2009-06-24 20:33 ` Al Viro
2009-06-24 20:38 ` Al Viro
2009-06-24 20:41 ` Linus Torvalds
2009-06-24 20:47 ` Al Viro
2009-06-24 21:09 ` Al Viro
2009-06-24 21:22 ` Frans Pop
2009-06-24 20:46 ` Markus Trippelsdorf
2009-06-24 20:49 ` Al Viro [this message]
2009-06-24 21:04 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090624204906.GV8633@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.