From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MJZTW-0001gK-BF for mharc-grub-devel@gnu.org; Wed, 24 Jun 2009 16:53:46 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJZTU-0001fl-Rc for grub-devel@gnu.org; Wed, 24 Jun 2009 16:53:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJZTQ-0001dW-A4 for grub-devel@gnu.org; Wed, 24 Jun 2009 16:53:44 -0400 Received: from [199.232.76.173] (port=42362 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJZTQ-0001dO-5x for grub-devel@gnu.org; Wed, 24 Jun 2009 16:53:40 -0400 Received: from aybabtu.com ([69.60.117.155]:39241) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MJZTP-0007q9-PA for grub-devel@gnu.org; Wed, 24 Jun 2009 16:53:39 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MJYQD-0005nZ-BI for grub-devel@gnu.org; Wed, 24 Jun 2009 21:46:17 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MJZTN-0001FF-2Q for grub-devel@gnu.org; Wed, 24 Jun 2009 22:53:37 +0200 Date: Wed, 24 Jun 2009 22:53:37 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090624205337.GA4760@thorin> References: <20090624120651.GB1429@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: [PATCH] Support splitting SOURCE in multiple rmk files X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jun 2009 20:53:45 -0000 On Wed, Jun 24, 2009 at 08:13:35PM +0800, Bean wrote: > >> +bin_UTILITIES += grub-mkelfimage > >> +grub_mkelfimage_SOURCES = util/resolve.c > >> + > >>  pkglib_MODULES += cpuid.mod > >>  cpuid_mod_SOURCES = commands/i386/cpuid.c > >>  cpuid_mod_CFLAGS = $(COMMON_CFLAGS) > > > > This looks very confusing.  If what is actually doing is append a new > > string to the grub_mkelfimage_SOURCES variable, why not with "+=" ? > > > > "=" means override the previous value. > > Hi, > > You can use = or +=, actually the macro is used by genmk.rb to > generate the rules, it's not used by Makefile itself, so no problem > overriding it. Yes, but using = to generate a rule that actually means += is very confusing. Please don't do that. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."