Re: [PATCH 1/1] I2C: I2C controller driver for Intel Moorestown platform

[Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>]

Hi Wen,

On Fri, 26 Jun 2009 10:41:07 +0800, Wang, Wen W wrote:
> Hi Jean,
> 
> Really appreciate your kindly comments on Moorestown I2C driver! I'm really learning a lot from your comments. :)
> 
> Currently I'm working on those comments, but due to other plenty of work, please expect a slow response on that. :(
> 
> Another thing needs your help is, can I replace the module_init() function with subsys_initcall() in Moorestown I2C driver? Is it acceptable for I2C subsystem? 

Yes, using subsys_initcall() is acceptable, a number of i2c bus drivers
for embedded platforms do that already (i2c-pxa and i2c-omap.c for
example.)

> There is a requirement in Moorestown that certain drivers need I2C driver loaded before those drivers. To achieve this, is subsys_initcall() the only way?

I can't say whether this is the only way given than you mentioned no
detail about the requirements, but this is one possible way for sure.

-- 
Jean Delvare