From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MKEq6-0001QC-2a for mharc-grub-devel@gnu.org; Fri, 26 Jun 2009 13:03:50 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MKEq4-0001Or-Oh for grub-devel@gnu.org; Fri, 26 Jun 2009 13:03:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MKEpz-0001L4-Au for grub-devel@gnu.org; Fri, 26 Jun 2009 13:03:47 -0400 Received: from [199.232.76.173] (port=38740 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MKEpz-0001Km-6I for grub-devel@gnu.org; Fri, 26 Jun 2009 13:03:43 -0400 Received: from aybabtu.com ([69.60.117.155]:58393) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MKEpy-0006F2-Ak for grub-devel@gnu.org; Fri, 26 Jun 2009 13:03:42 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MKDmb-0004sA-02 for grub-devel@gnu.org; Fri, 26 Jun 2009 17:56:09 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MKEpv-0005x8-5n for grub-devel@gnu.org; Fri, 26 Jun 2009 19:03:39 +0200 Date: Fri, 26 Jun 2009 19:03:39 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090626170339.GA22854@thorin> References: <1245720581.30815.11.camel@mj> <20090623113850.GB24028@thorin> <20090623121325.GA3130@thorin> <20090624010032.GA19305@thorin> <20090624231005.GA30986@thorin> <1245959608.18261.64.camel@mj> <20090625203108.GB4344@thorin> <1245963071.3196.6.camel@mj> <20090626144107.GA21789@thorin> <1246034647.1036.39.camel@mj> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1246034647.1036.39.camel@mj> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jun 2009 17:03:49 -0000 On Fri, Jun 26, 2009 at 12:44:07PM -0400, Pavel Roskin wrote: > On Fri, 2009-06-26 at 16:41 +0200, Robert Millan wrote: > > On Thu, Jun 25, 2009 at 04:51:11PM -0400, Pavel Roskin wrote: > > > > > > I'd like to avoid preprocessor conditionals in kern/ARCH/dl.c files if > > > possible. > > > > Alright, here's a new patch. It follows your earlier suggestion to use > > a wrapper to obtain the initialization address for symtab. This way we > > don't put any ifdefs in kern/ARCH/dl.c files. > > > > I also avoid the #undefs in efiemu. This required many changes in > > loadcore.c, but they're just a sed search & replace run. > > More redefinitions are needed to make all platforms compile. At this > point I think maybe we should try something less intrusive. But anyway, > 02-elf-renames.patch contains those renames. > > 03-simple-symtab.patch simplifies the logic in kern/ARCH/dl.c files. 03-simple-symtab.patch looks nice, much cleaner than what I had. But as for 02-elf-renames.patch we could try to make this more consistent. In efiemu I used 'W' (inspired by ElfW() macro in glibc), then in some places you use 'K' and in other places 'T'. Can we use the same everywhere? I don't care which letter, I'm not THAT much into bikeshed :-) -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."