From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: David Miller <davem@davemloft.net>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] IDE: ide-taskfile.c fix compilation warning and cleanup
Date: Fri, 26 Jun 2009 21:42:42 +0200 [thread overview]
Message-ID: <200906262142.43102.bzolnier@gmail.com> (raw)
In-Reply-To: <1245986290.3568.1.camel@hpdv5.satnam>
On Friday 26 June 2009 05:18:10 Jaswinder Singh Rajput wrote:
> On Mon, 2009-06-22 at 12:50 +0200, Bartlomiej Zolnierkiewicz wrote:
> > Besides I would suggest splitting the patch on fix and cleanup parts.
>
> Here is the cleanup part:
>
> [PATCH] IDE: ide-taskfile.c fix style problems
>
> Fix trivial style problems:
>
> WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
> WARNING: space prohibited between function name and open parenthesis '('
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> ERROR: do not use C99 // comments X 2
> ERROR: trailing statements should be on next line
> ERROR: trailing whitespace
> ERROR: switch and case should be at the same indent
> WARNING: line over 80 characters
>
> total: 5 errors, 4 warnings
>
> Also removed dead code
>
> Also used pr_err() to avoid line breaks
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
next prev parent reply other threads:[~2009-06-26 19:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 6:09 [PATCH] IDE: ide-taskfile.c fix compilation warning and cleanup Jaswinder Singh Rajput
2009-06-22 6:21 ` David Miller
2009-06-22 10:50 ` Bartlomiej Zolnierkiewicz
2009-06-26 3:18 ` Jaswinder Singh Rajput
2009-06-26 19:42 ` Bartlomiej Zolnierkiewicz [this message]
2009-06-27 9:18 ` Jaswinder Singh Rajput
2009-08-03 3:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906262142.43102.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=davem@davemloft.net \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.