From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MKVw3-0002Qx-V9 for mharc-grub-devel@gnu.org; Sat, 27 Jun 2009 07:19:08 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MKVvz-0002Qd-F2 for grub-devel@gnu.org; Sat, 27 Jun 2009 07:19:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MKVvs-0002Q0-S9 for grub-devel@gnu.org; Sat, 27 Jun 2009 07:19:01 -0400 Received: from [199.232.76.173] (port=58037 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MKVvr-0002Pn-Ok for grub-devel@gnu.org; Sat, 27 Jun 2009 07:18:56 -0400 Received: from aybabtu.com ([69.60.117.155]:57581) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MKVvr-0005Be-Ag for grub-devel@gnu.org; Sat, 27 Jun 2009 07:18:55 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MKUsP-0007e3-NN for grub-devel@gnu.org; Sat, 27 Jun 2009 12:11:18 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MKVvo-0007Re-Dv for grub-devel@gnu.org; Sat, 27 Jun 2009 13:18:52 +0200 Date: Sat, 27 Jun 2009 13:18:52 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090627111852.GA17476@thorin> References: <20090625203108.GB4344@thorin> <1245963071.3196.6.camel@mj> <20090626144107.GA21789@thorin> <1246034647.1036.39.camel@mj> <20090626170339.GA22854@thorin> <1246036617.6207.6.camel@mj> <20090626174333.GA23300@thorin> <1246055217.20234.26.camel@mj> <20090626235707.GA26038@thorin> <1246072103.13388.74.camel@mj> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1246072103.13388.74.camel@mj> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: [PATCH] fix for loading modules from read-only memory area (Re: clean patch for i386-qemu port (Re: [PATCH] i386-qemu port)) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jun 2009 11:19:04 -0000 On Fri, Jun 26, 2009 at 11:08:23PM -0400, Pavel Roskin wrote: > On Sat, 2009-06-27 at 01:57 +0200, Robert Millan wrote: > > On Fri, Jun 26, 2009 at 06:26:57PM -0400, Pavel Roskin wrote: > > > --- a/include/grub/elf.h > > > +++ b/include/grub/elf.h > > > @@ -2330,4 +2330,48 @@ typedef Elf32_Addr Elf32_Conflict; > > > > > > #define R_X86_64_NUM 24 > > > > > > +#ifndef DEFAULT_ELF_BITS > > > +#define DEFAULT_ELF_BITS (8 * GRUB_TARGET_SIZEOF_VOID_P) > > > +#endif > > > > Nice trick. But it's not ELF-specific, so why not put it in the > > same header that defines GRUB_TARGET_SIZEOF_VOID_P ? (with a different > > name of course) > > Good idea! Now it's GRUB_TARGET_WORDSIZE. The first patch has been > committed. Ok but note that word size == pointer size is not always true. In fact I'm working on a project where it isn't :-) (if you're curious: https://savannah.gnu.org/task/?9437) > The second patch should probably go after the qemu patch. Actually, the qemu port won't work without the second patch. I just merged it with mine and made a joint commit (ROM + qemu). -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."