All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Kaz Kylheku <KKylheku@zeugmasystems.com>
Cc: Aurelien Jarno <aurelien@aurel32.net>, linux-mips@linux-mips.org
Subject: Re: Broadcom Swarm support
Date: Sat, 27 Jun 2009 16:49:02 +0100	[thread overview]
Message-ID: <20090627154902.GA18139@linux-mips.org> (raw)
In-Reply-To: <DDFD17CC94A9BD49A82147DDF7D545C501C3539B@exchange.ZeugmaSystems.local>

On Wed, Jun 24, 2009 at 03:18:24PM -0700, Kaz Kylheku wrote:

> +void __flush_icache_page(struct vm_area_struct *vma, struct page *page)
> +{
> +	if (vma->vm_flags & VM_EXEC)
> +		flush_icache_range((unsigned long) page_address(page),
> PAGE_SIZE); 
> +}

Flush_icache_range takes two arguments, start and end address.  Both
addresses are the virtual addresses at which the code will run.  Iow both
arguments are wrong.  The result is that for start address values normally
passed to flush_icache_range it will optimize the flush into a full cache
flush of I-cache and D-cache - iow you're lucky.

  Ralf

  parent reply	other threads:[~2009-06-27 15:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-24  6:34 Broadcom Swarm support Aurelien Jarno
2009-06-24 22:18 ` Kaz Kylheku
2009-06-24 22:18   ` Kaz Kylheku
2009-06-25  1:48   ` icache flushing (Re: Broadcom Swarm support) Atsushi Nemoto
2009-06-26 21:19   ` Broadcom Swarm support Aurelien Jarno
2009-06-26 23:24   ` Ralf Baechle
2009-06-27  5:10     ` Aurelien Jarno
2009-06-27  9:14       ` Ralf Baechle
2009-06-27 13:59     ` Atsushi Nemoto
2009-06-27 15:48       ` Ralf Baechle
2009-06-27 16:09         ` Atsushi Nemoto
2009-06-27 16:11           ` Atsushi Nemoto
2009-06-29 19:08           ` Ralf Baechle
2009-06-30 14:00             ` Atsushi Nemoto
2009-07-06 13:56               ` Atsushi Nemoto
2009-06-27 15:49   ` Ralf Baechle [this message]
2009-06-30 17:10     ` Kaz Kylheku
2009-06-30 17:10       ` Kaz Kylheku

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090627154902.GA18139@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=KKylheku@zeugmasystems.com \
    --cc=aurelien@aurel32.net \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.