From: Florian Fainelli <florian@openwrt.org>
To: Shane McDonald <mcdonald.shane@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH] fix build failures on msp_irq_slp.c
Date: Sun, 28 Jun 2009 07:01:29 +0200 [thread overview]
Message-ID: <200906280701.32649.florian@openwrt.org> (raw)
In-Reply-To: <b2b2f2320904290718pe9a28efy9a8af432887778cb@mail.gmail.com>
Hi Shane,
Le Wednesday 29 April 2009 16:18:11 Shane McDonald, vous avez écrit :
> Hello:
>
> On Wed, Apr 29, 2009 at 7:12 AM, Florian Fainelli
<florian@openwrt.org>wrote:
> > Hi Ralf, Shane,
> >
> > Le Wednesday 29 April 2009 13:58:59 Ralf Baechle, vous avez écrit :
> > > The whole irq chip thing in this file is looking suspect as it treats
> > > acknowledging and mask an interrupt as the same thing. Sure that is
> > > the right thing?
> >
> > That is a quick and dirty fix which compiles, I assumed that the function
> > meant to be called is mask_msp_slp_irq, Shane probably knows more about
> > how this should be fixed.
>
> It's been quite a while since I messed around with the 4200. I'll do some
> digging and ask some questions of guys who probably know better.
Any updates on that patch ? Thank you very much.
--
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------
next prev parent reply other threads:[~2009-06-28 5:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-27 14:59 [PATCH] fix build failures on msp_irq_slp.c Florian Fainelli
2009-04-29 11:58 ` Ralf Baechle
2009-04-29 13:12 ` Florian Fainelli
2009-04-29 14:18 ` Shane McDonald
2009-06-28 5:01 ` Florian Fainelli [this message]
2009-07-11 10:51 ` Shane McDonald
2009-07-12 16:34 ` Shane McDonald
2009-07-12 16:42 ` Florian Fainelli
2009-07-13 11:53 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906280701.32649.florian@openwrt.org \
--to=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=mcdonald.shane@gmail.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.