From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MKsnz-0008O6-9N for mharc-grub-devel@gnu.org; Sun, 28 Jun 2009 07:44:19 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MKsnx-0008O1-Fw for grub-devel@gnu.org; Sun, 28 Jun 2009 07:44:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MKsnt-0008Np-0g for grub-devel@gnu.org; Sun, 28 Jun 2009 07:44:17 -0400 Received: from [199.232.76.173] (port=35643 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MKsns-0008Nm-SS for grub-devel@gnu.org; Sun, 28 Jun 2009 07:44:12 -0400 Received: from aybabtu.com ([69.60.117.155]:58105) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MKsns-0001vR-I4 for grub-devel@gnu.org; Sun, 28 Jun 2009 07:44:12 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MKrkJ-0007PM-Qj; Sun, 28 Jun 2009 12:36:28 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MKsno-0006yE-Es; Sun, 28 Jun 2009 13:44:08 +0200 Date: Sun, 28 Jun 2009 13:44:08 +0200 From: Robert Millan To: Felix Zielcke Message-ID: <20090628114408.GE16893@thorin> References: <20090620134351.GA22660@thorin> <1246184616.3478.1.camel@fz.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1246184616.3478.1.camel@fz.local> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Cc: grub-devel@gnu.org Subject: Re: [2338] 2009-06-17 Felix Zielcke X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jun 2009 11:44:17 -0000 On Sun, Jun 28, 2009 at 12:23:36PM +0200, Felix Zielcke wrote: > Am Samstag, den 20.06.2009, 15:43 +0200 schrieb Robert Millan: > > Hi Felix, > > > > This commit looks wrong. grub_file_open is already supposed to set > > grub_errno and grub_errmsg appropiately. > > > > Is there a specific problem you wanted to fix here? > > If the loaded file can't be found, the menuentry code just continuesa > and initrd then complains that you must load the kernel first. Thanks. Looking at the patch, the only possible explanation for this is that grub_file_open() returned 0 but didn't set grub_errno. I'll try to find a moment to debug this. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."