All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso-3s7WtUTddSA@public.gmane.org>
To: Scott James Remnant <scott-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
Cc: Karel Zak <kzak-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Andrey Borzenkov <arvidjaar-JGs/UdohzUI@public.gmane.org>,
	util-linux-ng-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))
Date: Sun, 28 Jun 2009 09:34:30 -0400	[thread overview]
Message-ID: <20090628133430.GA3594@mit.edu> (raw)
In-Reply-To: <1244021945.4120.4.camel@quest>

Sorry for the delay; I've been incredibly busy.  I'm guessing you
never actually bothered to build and test the patch which you
submitted?

I tried building with --disable-libuuid, when it tried to compile
e2fsck, it crashed and burned.  The reason why was because LIBUUID
wasn't getting set properly:

% grep LIBUUID MCONFIG  | head -1
LIBUUID =  

And the reason for that is....

On Wed, Jun 03, 2009 at 10:39:05AM +0100, Scott James Remnant wrote:
> +AC_ARG_ENABLE([libuuid],
> +[  --disable-libuuid	  do not build private uuid library],
> +if test "$enableval" = "no"
> +then
> +	if test -z "$PKG_CONFIG"; then
> +		AC_MSG_ERROR([pkg-config not installed; please install it.])
> +	fi
> +
> +	AC_CHECK_LIB(uuid, uuid_generate,
> +		[LIBBLKID=`$PKG_CONFIG --libs uuid`;
                 ^^^^^^^^
> +		 STATIC_LIBBLKID=`$PKG_CONFIG --static --libs uuid`],
                 ^^^^^^^^^^^^^^^
> +		[AC_MSG_ERROR([external uuid library not found])],
> +		[$LIBUUID])
> +	UUID_CMT=#
> +	AC_MSG_RESULT([Disabling private uuid library])

I'll have a corrected patch checked into e2fsprogs.

							- Ted
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2009-06-28 13:34 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200905311113.23004.arvidjaar@mail.ru>
     [not found] ` <20090601124857.GF31943@mit.edu>
     [not found]   ` <20090601124857.GF31943-3s7WtUTddSA@public.gmane.org>
2009-06-03  8:51     ` libuuid (Re: blkid: util-linux-ng vs. e2fsprogs) Karel Zak
     [not found]       ` <1244021945.4120.4.camel@quest>
2009-06-16 13:36         ` [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs)) Scott James Remnant
2009-06-18  0:27           ` Kay Sievers
2009-06-28 13:34         ` Theodore Tso [this message]
2009-06-30 10:17           ` Kay Sievers
2009-07-01 21:43             ` Theodore Tso
     [not found]               ` <20090701214345.GG17054-3s7WtUTddSA@public.gmane.org>
2009-07-01 21:52                 ` Kay Sievers
2009-07-01 22:35                   ` Mike Frysinger
     [not found]                     ` <200907011835.08501.vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2009-07-01 22:39                       ` Kay Sievers
     [not found]                         ` <ac3eb2510907011539k3e2fb664g59ec4dc6f1ae5e0a-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-07-01 23:04                           ` Mike Frysinger
2009-07-02  0:58                     ` Theodore Tso
2009-07-02  1:15                       ` Mike Frysinger
     [not found]                         ` <200907012115.57826.vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2009-07-02 12:49                           ` Kay Sievers
2009-07-02 14:25                             ` Theodore Tso
2009-07-02 14:48                               ` Kay Sievers
2009-07-02 15:51                               ` Mike Frysinger
     [not found]                                 ` <200907021151.10268.vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2009-07-02 16:24                                   ` Theodore Tso
     [not found]           ` <20090628133430.GA3594-3s7WtUTddSA@public.gmane.org>
2009-07-01 21:04             ` [PATCH] configure.in: add --disable-libuuid option (Was:libuuid " Matthew Burgess
2009-07-01 21:28               ` Theodore Tso
     [not found]                 ` <20090701212844.GC17054-3s7WtUTddSA@public.gmane.org>
2009-07-01 21:42                   ` Mike Frysinger
     [not found]                     ` <200907011742.28028.vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2009-07-02  2:26                       ` Theodore Tso
     [not found]                         ` <20090702022652.GI17054-3s7WtUTddSA@public.gmane.org>
2009-07-02  2:41                           ` Mike Frysinger
     [not found]                             ` <200907012241.08962.vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2009-07-02  4:03                               ` Theodore Tso
     [not found]                                 ` <20090702040353.GB2923-3s7WtUTddSA@public.gmane.org>
2009-07-02  4:35                                   ` Mike Frysinger
2009-07-01 21:56                   ` Kay Sievers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090628133430.GA3594@mit.edu \
    --to=tytso-3s7wtutddsa@public.gmane.org \
    --cc=arvidjaar-JGs/UdohzUI@public.gmane.org \
    --cc=kzak-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=scott-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org \
    --cc=util-linux-ng-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.