From: Oliver Neukum <oliver@neukum.org>
To: Arseniy Lartsev <ars3n@yandex.ru>, USB list <linux-usb@vger.kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PROBLEM: USB ACM device does not work
Date: Sun, 28 Jun 2009 22:58:07 +0200 [thread overview]
Message-ID: <200906282258.08277.oliver@neukum.org> (raw)
In-Reply-To: <200906282229.35713.ars3n@yandex.ru>
Am Sonntag, 28. Juni 2009 20:29:26 schrieb Arseniy Lartsev:
> The reason is that the driver calls usb_submit_urb in acm_start_wb()
> but doesn't set interval in the urb structure, so it remains zero and
> causes usb_submit_urb to return -EINVAL. Reading from device also does
That simply does not make sense. Have you confirmed that this check:
switch (xfertype) {
case USB_ENDPOINT_XFER_ISOC:
case USB_ENDPOINT_XFER_INT:
/* too small? */
if (urb->interval <= 0)
return -EINVAL;
really triggers?
Regards
Oliver
next prev parent reply other threads:[~2009-06-28 20:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-28 18:29 PROBLEM: USB ACM device does not work Arseniy Lartsev
2009-06-28 20:20 ` Oliver Neukum
2009-06-28 20:37 ` Arseniy Lartsev
2009-06-28 20:58 ` Oliver Neukum [this message]
2009-06-29 11:43 ` Arseniy Lartsev
2009-06-29 13:07 ` Oliver Neukum
2009-06-29 13:35 ` Arseniy Lartsev
2009-06-30 7:22 ` Oliver Neukum
2009-06-30 20:09 ` Arseniy Lartsev
2009-06-30 21:01 ` Alan Stern
2009-07-01 9:01 ` Arseniy Lartsev
2009-07-01 10:56 ` Oliver Neukum
2009-07-01 11:24 ` Arseniy Lartsev
2009-07-01 11:37 ` Oliver Neukum
2009-07-01 12:27 ` [PATCH] cdc-acm: work around some broken devices Arseniy Lartsev
2009-07-01 13:56 ` Greg KH
2009-07-01 14:03 ` Oliver Neukum
2009-07-01 14:34 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906282258.08277.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=ars3n@yandex.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.