From: Theodore Tso <tytso@mit.edu>
To: number9652 <number9652@yahoo.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] libext2fs: ensure validate_entry doesn't read beyond blocksize
Date: Mon, 29 Jun 2009 01:27:01 -0400 [thread overview]
Message-ID: <20090629052701.GD6802@mit.edu> (raw)
In-Reply-To: <687495.40108.qm@web43515.mail.sp1.yahoo.com>
On Fri, Jun 12, 2009 at 09:04:32AM -0700, number9652 wrote:
>
> ext2fs_validate_entry would read beyond the end of the block to get dirent->rec_len for certain arguments (like if blocksize == final_offset). This patch adds a check so that doesn't happen, and changes the types of the arguments to avoid a compiler warning.
>
> Signed-off-by: Nic Case <number9652@yahoo.com>
Applied. In the future, please line-wrap the body of the commit
message at 72-75 characters.
I also lined up the arguments to ext2fs_validate_entry on the
continuation line, and used a CPP macro instead of an automatic
variable for dirent_min_length.
- Ted
prev parent reply other threads:[~2009-06-29 5:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 16:04 [PATCH] libext2fs: ensure validate_entry doesn't read beyond blocksize number9652
2009-06-29 5:27 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090629052701.GD6802@mit.edu \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=number9652@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.