From: Frederic Weisbecker <fweisbec@gmail.com>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Ingo <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing/syscall: remove redundant code
Date: Mon, 29 Jun 2009 13:13:36 +0200 [thread overview]
Message-ID: <20090629111334.GA6265@nowhere> (raw)
In-Reply-To: <4A488667.6040004@cn.fujitsu.com>
On Mon, Jun 29, 2009 at 05:16:23PM +0800, Xiao Guangrong wrote:
> No need to call trace_wake_up() explicitly because it's called
> in trace_current_buffer_unlock_commit().
>
> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
> ---
> kernel/trace/trace_syscalls.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
> index 5e57964..dd1ce2c 100644
> --- a/kernel/trace/trace_syscalls.c
> +++ b/kernel/trace/trace_syscalls.c
> @@ -168,7 +168,6 @@ void ftrace_syscall_enter(struct pt_regs *regs)
> syscall_get_arguments(current, regs, 0, sys_data->nb_args, entry->args);
>
> trace_current_buffer_unlock_commit(event, 0, 0);
> - trace_wake_up();
> }
>
> void ftrace_syscall_exit(struct pt_regs *regs)
> @@ -194,7 +193,6 @@ void ftrace_syscall_exit(struct pt_regs *regs)
> entry->ret = syscall_get_return_value(current, regs);
>
> trace_current_buffer_unlock_commit(event, 0, 0);
> - trace_wake_up();
> }
>
> static int init_syscall_tracer(struct trace_array *tr)
> --
> 1.6.1.2
>
Thanks,
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
prev parent reply other threads:[~2009-06-29 11:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 9:16 [PATCH] tracing/syscall: remove redundant code Xiao Guangrong
2009-06-29 11:13 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090629111334.GA6265@nowhere \
--to=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.