From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: at_keyboard flush on i386-qemu
Date: Mon, 29 Jun 2009 15:33:15 +0200 [thread overview]
Message-ID: <20090629133315.GB20463@thorin> (raw)
In-Reply-To: <1246248175.22661.19.camel@mj>
On Mon, Jun 29, 2009 at 12:02:55AM -0400, Pavel Roskin wrote:
>
> I would just read and discard the keyboard data from the port at startup
> without embedding at_keyboard.
Seems fine.
> > I don't like that we have a race here. Suggestions welcome on how to
> > improve that, but TTBOMK if there's more than one event you can't tell
> > when you're processing the last one.
>
> I think there is at most one event.
Actually, you need two events for a single key press (MAKE + BREAK), and
I've seen it print two keys sometimes.
> And I suspect it's due to a qemu
> bug.
Well, other firmwares (coreboot, bios.bin) don't have this problem. It's
probably something that you need to do on real hardware anyway (which we
might want to support someday).
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
next prev parent reply other threads:[~2009-06-29 13:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-27 11:25 at_keyboard flush on i386-qemu Robert Millan
2009-06-29 4:02 ` Pavel Roskin
2009-06-29 13:33 ` Robert Millan [this message]
2009-06-30 1:01 ` Pavel Roskin
2009-07-07 19:51 ` [PATCH] use ljmp to reboot (Re: at_keyboard flush on i386-qemu) Robert Millan
2009-07-07 20:51 ` Pavel Roskin
2009-07-10 17:07 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090629133315.GB20463@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.