From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MLHFz-0007lr-Nt for mharc-grub-devel@gnu.org; Mon, 29 Jun 2009 09:50:51 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MLHFx-0007i6-4m for grub-devel@gnu.org; Mon, 29 Jun 2009 09:50:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MLHFs-0007dr-9m for grub-devel@gnu.org; Mon, 29 Jun 2009 09:50:48 -0400 Received: from [199.232.76.173] (port=50685 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MLHFr-0007dR-Hm for grub-devel@gnu.org; Mon, 29 Jun 2009 09:50:43 -0400 Received: from aybabtu.com ([69.60.117.155]:60928) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MLHFr-0006nI-3A for grub-devel@gnu.org; Mon, 29 Jun 2009 09:50:43 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MLGCD-00032f-N5 for grub-devel@gnu.org; Mon, 29 Jun 2009 14:42:54 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MLHFo-0002TT-6x for grub-devel@gnu.org; Mon, 29 Jun 2009 15:50:40 +0200 Date: Mon, 29 Jun 2009 15:50:40 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090629135040.GD20463@thorin> References: <20090628123526.GA18813@thorin> <87r5x48o56.fsf@xs4all.nl> <20090628145207.GA7184@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: regression in hiddenmenu (Re: [2158] 2009-05-02 Bean ) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2009 13:50:49 -0000 On Sun, Jun 28, 2009 at 10:59:31PM +0800, Bean wrote: > Hi, > > Actually that's not the cause. The call order is right, it's just that > the normal reader would clear screen and print an header in its init > function. If you want to change it, you can move those code to the > menu viewer, but I guess Colin is about to commit his menu viewer > patch, I think it would be better to leave it alone for now to > minimize code conflict. Uhm I just noticed if you convert grub_cls() to a stub, you'll see the menu header being printed twice. Could this be related? If we're printing the header a second time unnecessarily, we could just remove the first one. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."