All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Len Brown <lenb@kernel.org>,
	Vegard Nossum <vegard.nossum@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Corentin Chary <corentincj@iksaif.net>,
	Randy Dunlap <randy.dunlap@oracle.com>,
	Matthew Garrett <mjg@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH, v3] eeepc-laptop: Fix build failure with HOTPLUG_PCI && !SYSFS (was: [git pull request] ACPI & driver patches for 2.6.31-rc1)
Date: Mon, 29 Jun 2009 22:43:50 +0200	[thread overview]
Message-ID: <20090629204350.GA8253@uranus.ravnborg.org> (raw)
In-Reply-To: <20090629193406.GA30774@elte.hu>

On Mon, Jun 29, 2009 at 09:34:06PM +0200, Ingo Molnar wrote:
> 
> * Len Brown <lenb@kernel.org> wrote:
> 
> > Thanks for fixing this config, Ingo.
> > 
> > I agree, our build system can handle "depends",
> > but "select" does not deliver on what it advertises,
> > making it a trap for programmers.
> 
> Hm, this portion of Kconfig is a trap in a way indeed - on the other 
> hand it is also a useful tool and the simplistic approach to 
> disallow select altogether is a step backwards.
> 
> IIRC either Vegard or Steve has come up with a patch series that 
> improved Kconfig to warn about problem selects while still allowing 
> the simple ones. That would deflect most of the bad uses while still 
> allowing the good uses. Not sure what happened to that series.

Steve came up with a patch that warned about problematic select
only in a defconfig. It did not warn properly for all the problematic
selects.
I ran (as usual) out of time last time I looked :-(
I would likely need a full day or two to come up with somthing,
but these days finding an hour is not easy.

	Sam

      reply	other threads:[~2009-06-29 20:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-26  4:27 [git pull request] ACPI & driver patches for 2.6.31-rc1 Len Brown
2009-06-29  8:07 ` [PATCH] eeepc-laptop: Fix build failure with HOTPLUG_PCI && !SYSFS (was: [git pull request] ACPI & driver patches for 2.6.31-rc1) Ingo Molnar
2009-06-29  8:10   ` [PATCH, v2] " Ingo Molnar
2009-06-29  8:13     ` [PATCH, v3] " Ingo Molnar
2009-06-29 15:27       ` [PATCH, v3] eeepc-laptop: Fix build failure with HOTPLUG_PCI && !SYSFS Randy Dunlap
2009-06-29 15:39       ` [PATCH, v3] eeepc-laptop: Fix build failure with HOTPLUG_PCI && !SYSFS (was: [git pull request] ACPI & driver patches for 2.6.31-rc1) Len Brown
2009-06-29 19:34         ` Ingo Molnar
2009-06-29 20:43           ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090629204350.GA8253@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@linux-foundation.org \
    --cc=corentincj@iksaif.net \
    --cc=hpa@zytor.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mjg@redhat.com \
    --cc=randy.dunlap@oracle.com \
    --cc=rostedt@goodmis.org \
    --cc=torvalds@linux-foundation.org \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.