From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MLaMf-0006zj-OR
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 06:15:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MLaMa-0006x5-Bq
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 06:15:01 -0400
Received: from [199.232.76.173] (port=53564 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MLaMa-0006wu-3B
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 06:14:56 -0400
Received: from wa4ehsobe005.messaging.microsoft.com ([216.32.181.15]:50680
	helo=WA4EHSOBE006.bigfish.com)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_MD5:16)
	(Exim 4.60) (envelope-from <Christoph.Egger@amd.com>)
	id 1MLaMZ-0001zZ-Og
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 06:14:55 -0400
From: Christoph Egger <Christoph.Egger@amd.com>
Subject: Re: [Qemu-devel] [PATCH] buildfix: unknown
	=?iso-8859-1?q?option=09?="-Wno-error=uninitialized"
Date: Tue, 30 Jun 2009 12:14:42 +0200
References: <200906301115.34111.Christoph.Egger@amd.com>
	<4A49E365.40307@redhat.com>
In-Reply-To: <4A49E365.40307@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-ID: <200906301214.42875.Christoph.Egger@amd.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org

On Tuesday 30 June 2009 12:05:25 Avi Kivity wrote:
> On 06/30/2009 12:15 PM, Christoph Egger wrote:
> > diff --git a/rules.mak b/rules.mak
> > index defee1d..8561289 100644
> > --- a/rules.mak
> > +++ b/rules.mak
> > @@ -1,6 +1,6 @@
> >
> >   %.o: %.c
> > -	$(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -Werror
> > -Wno-error=uninitialized -c -o $@ $<,"  CC    $(TARGET_DIR)$@") +	$(call
> > quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -Werror -c -o $@ $<,"  CC   
> > $(TARGET_DIR)$@")
> >
> >   %.o: %.S
> >   	$(call quiet-command,$(CC) $(CPPFLAGS) -c -o $@ $<,"  AS   
> > $(TARGET_DIR)$@")
>
> Should remove the -Werror too, it's set by ./configure.

Will you do this between applying the patch and 'git commit' or should I 
resend a diff ?

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632