All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Mike Galbraith <efault@gmx.de>
Cc: Alexander van Heukelum <heukelum@fastmail.fm>,
	LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [patch] x86: fix arch/x86/lib/clear_page_64.S::clear_page_c annotation
Date: Tue, 30 Jun 2009 17:51:18 +0400	[thread overview]
Message-ID: <20090630135118.GC5532@lenovo> (raw)
In-Reply-To: <1246366820.6538.1.camel@marge.simson.net>

[Mike Galbraith - Tue, Jun 30, 2009 at 03:00:20PM +0200]
| On Tue, 2009-06-30 at 13:42 +0200, Alexander van Heukelum wrote:
| > Hi Mike,
| > 
| > I agree with the code, but I do have a remark...
| > 
| > The ENTRY() macro already includes the ALIGN, so you could get
| > rid of the preceding ALIGN. But it's just a neatness thing, because
| > two consecutive ALIGNS don't change the resulting binary.
| > 
| > At any rate:
| > 
| > Acked-by: Alexander van Heukelum <heukelum@fastmail.fm>
| > 
| > (maybe the x86-committer feels comfortable enough to remove the ALIGN ;)
| > )
| 
| No doubt, but I can save him the trouble ;-)
| 
| x86: fix incorrect arch/x86/lib/clear_page_64.S::clear_page_c annotation.
| 
| Signed-off-by: Mike Galbraith <efault@gmx.de>
| Acked-by: Alexander van Heukelum <heukelum@fastmail.fm>
| Cc: Ingo Molnar <mingo@elte.hu>
| Cc: Cyrill Gorcunov <gorcunov@gmail.com>
| LKML-Reference: <new-submission>
| 
| ---
|  arch/x86/lib/clear_page_64.S |    5 ++---
|  1 file changed, 2 insertions(+), 3 deletions(-)
|
...

Thanks Mike, here is my Ack (if needed)

Acked-by: Cyrill Gorcunov <gorcunov@openvz.org>
 
	-- Cyrill

  reply	other threads:[~2009-06-30 13:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-30 10:54 [patch] x86: fix arch/x86/lib/clear_page_64.S::clear_page_c annotation Mike Galbraith
2009-06-30 11:42 ` Alexander van Heukelum
2009-06-30 13:00   ` Mike Galbraith
2009-06-30 13:51     ` Cyrill Gorcunov [this message]
2009-06-30 21:45     ` [tip:x86/urgent] x86: Fix symbol annotation for arch/x86/lib/clear_page_64.S::clear_page_c tip-bot for Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090630135118.GC5532@lenovo \
    --to=gorcunov@gmail.com \
    --cc=efault@gmx.de \
    --cc=heukelum@fastmail.fm \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.