From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Trilok Soni <soni.trilok@gmail.com>
Cc: "Leo (Hao) Chen" <leochen@broadcom.com>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
"linux-arm-kernel@lists.arm.linux.org.uk"
<linux-arm-kernel@lists.arm.linux.org.uk>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 3/6][ARM] new ARM SoC support: BCMRing
Date: Tue, 30 Jun 2009 22:12:49 +0100 [thread overview]
Message-ID: <20090630211249.GA10001@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <5d5443650906292230k27e70863l49566462328f0a43@mail.gmail.com>
On Tue, Jun 30, 2009 at 11:00:41AM +0530, Trilok Soni wrote:
> Hi Leo,
>
> > I'll fix the errors found by the checkpatch.pl script. Is it okay to pass the checkpatch.pl with some warnings?
> >
>
> I don't think so, but if you find any false positives you can report to ML.
The answer is actually yes. For instance, if you have a prink where
the string you're printing goes over the 80 column limit, you have two
choices:
1. wrap the string. This is considered bad practice since it means
that you can't grep the kernel source for the exact message.
2. leave the string as is and ignore the checkpatch warning.
(2) is considered better practice than (1).
next prev parent reply other threads:[~2009-06-30 21:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 23:26 [PATCH v1 1/6][ARM] new ARM SoC support: BCMRing Leo (Hao) Chen
2009-06-26 23:28 ` [PATCH v1 2/6][ARM] " Leo (Hao) Chen
2009-06-26 23:29 ` [PATCH v1 3/6][ARM] " Leo (Hao) Chen
2009-06-26 23:30 ` [PATCH v1 4/6][ARM] " Leo (Hao) Chen
2009-06-26 23:30 ` [PATCH v1 5/6][ARM] " Leo (Hao) Chen
2009-06-26 23:30 ` [PATCH v1 6/6][ARM] " Leo (Hao) Chen
2009-06-30 18:41 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-30 23:20 ` Alan Cox
2009-06-30 23:37 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-30 23:54 ` Leo (Hao) Chen
2009-06-30 23:57 ` Scott Branden
2009-07-01 12:00 ` Alan Cox
2009-06-30 18:42 ` [PATCH v1 5/6][ARM] " Jean-Christophe PLAGNIOL-VILLARD
2009-06-30 18:43 ` [PATCH v1 4/6][ARM] " Jean-Christophe PLAGNIOL-VILLARD
2009-06-27 5:33 ` [PATCH v1 3/6][ARM] " Jean-Christophe PLAGNIOL-VILLARD
2009-06-30 1:09 ` Leo (Hao) Chen
2009-06-30 5:30 ` Trilok Soni
2009-06-30 21:12 ` Russell King - ARM Linux [this message]
2009-06-30 22:29 ` Alessandro Rubini
2009-06-27 5:22 ` [PATCH v1 2/6][ARM] " Jean-Christophe PLAGNIOL-VILLARD
2009-06-27 5:21 ` [PATCH v1 1/6][ARM] " Jean-Christophe PLAGNIOL-VILLARD
[not found] <8628FE4E7912BF47A96AE7DD7BAC0AADCB25AE17C3@SJEXCHCCR02.corp.ad.broa dcom.com>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090630211249.GA10001@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=leochen@broadcom.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=soni.trilok@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.