From: Ralf Baechle <ralf@linux-mips.org>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Dmitri Vorobiev <dmitri.vorobiev@movial.com>, linux-mips@linux-mips.org
Subject: Re: [PATCH] [MIPS] Malta: Remove unneeded function protos from malta-reset.c
Date: Wed, 1 Jul 2009 07:31:16 +0100 [thread overview]
Message-ID: <20090701063116.GA6101@linux-mips.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0907010108380.23134@eddie.linux-mips.org>
On Wed, Jul 01, 2009 at 01:17:22AM +0100, Maciej W. Rozycki wrote:
> > There should be a tax on useless prototypes and also excessive parentheses ;-)
>
> And insufficient parentheses causing the average reader to refer to the
> language spec for the operator priority list. ;)
Code written to require intimate knowledge of all operator priorities is
probably as bad as overuse. Here a few examples:
return (1);
#define FOO (42)
a = (b + c);
a = (b + c) + d;
a = (b * c) + (d * e);
if ((a > b) && (a < c))
Ralf
next prev parent reply other threads:[~2009-07-01 6:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 16:59 [PATCH] [MIPS] Malta: Remove unneeded function protos from malta-reset.c Dmitri Vorobiev
2009-06-28 18:17 ` Ralf Baechle
2009-07-01 0:17 ` Maciej W. Rozycki
2009-07-01 6:31 ` Ralf Baechle [this message]
2009-07-01 15:46 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090701063116.GA6101@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=dmitri.vorobiev@movial.com \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.