From: Andi Kleen <andi@firstfloor.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Andi Kleen <andi@firstfloor.org>,
jolsa@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, fbl@redhat.com, nhorman@redhat.com,
davem@redhat.com, oleg@redhat.com, eric.dumazet@gmail.com
Subject: Re: [PATCH] net: fix race in the receive/select
Date: Wed, 1 Jul 2009 09:22:26 +0200 [thread overview]
Message-ID: <20090701072226.GN6760@one.firstfloor.org> (raw)
In-Reply-To: <20090701070332.GA31103@gondor.apana.org.au>
On Wed, Jul 01, 2009 at 03:03:32PM +0800, Herbert Xu wrote:
> On Wed, Jul 01, 2009 at 08:27:32AM +0200, Andi Kleen wrote:
> >
> > mfence is not needed for normal C code (not using non temporal
> > stores) in the Linux memory model on x86 and is a no-op. Only the compile
> > time barrier matters.
>
> In that case this bug needs to be digged deeper regardless of
> this patch.
Agreed.
I suspect the reordering of the wake queue tests might makes a difference, but
in this case to ensure they are always tested in the proper order by
the compiler would need more smp_rmb()s
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-07-01 7:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-25 12:25 [PATCH] net: fix race in the receive/select Jiri Olsa
2009-06-25 12:24 ` Oleg Nesterov
2009-06-26 1:31 ` Davide Libenzi
2009-06-26 1:59 ` Eric Dumazet
2009-06-26 2:04 ` Davide Libenzi
2009-06-26 2:11 ` David Miller
2009-06-26 2:19 ` Eric Dumazet
2009-06-26 3:14 ` Davide Libenzi
2009-06-26 5:42 ` Jarek Poplawski
2009-06-26 8:10 ` Jarek Poplawski
2009-06-26 13:57 ` Oleg Nesterov
2009-06-26 17:32 ` Davide Libenzi
2009-06-26 14:50 ` Oleg Nesterov
2009-06-26 18:12 ` Davide Libenzi
2009-06-26 18:17 ` David Miller
2009-06-26 19:35 ` Eric Dumazet
2009-06-29 9:34 ` Jiri Olsa
2009-06-28 11:10 ` Jarek Poplawski
2009-06-28 11:22 ` Jarek Poplawski
2009-06-28 18:04 ` Oleg Nesterov
2009-06-28 21:48 ` Jarek Poplawski
2009-06-29 9:27 ` Jiri Olsa
2009-06-26 13:46 ` Oleg Nesterov
2009-06-25 23:18 ` Eric Dumazet
2009-06-26 1:50 ` Tejun Heo
2009-06-29 9:12 ` Andi Kleen
2009-06-29 9:24 ` Jiri Olsa
2009-06-29 16:59 ` Zan Lynx
2009-06-29 17:29 ` Andi Kleen
2009-07-01 3:39 ` Herbert Xu
2009-07-01 6:27 ` Andi Kleen
2009-07-01 7:03 ` Herbert Xu
2009-07-01 7:22 ` Andi Kleen [this message]
2009-07-01 8:31 ` Herbert Xu
2009-07-01 8:44 ` Jiri Olsa
2009-07-01 10:58 ` Herbert Xu
2009-07-01 13:07 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090701072226.GN6760@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=davem@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=fbl@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.