From: Christoph Hellwig <hch@lst.de>
To: Alexander Graf <agraf@suse.de>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org,
Bique Alexandre <alexandre.bique@citrix.com>
Subject: Re: [Qemu-devel] [PATCH] ATAPI pass through
Date: Wed, 1 Jul 2009 10:44:59 +0200 [thread overview]
Message-ID: <20090701084459.GA3079@lst.de> (raw)
In-Reply-To: <0B4B4929-9F33-4F87-A1D3-16D56661E84B@suse.de>
On Wed, Jul 01, 2009 at 08:57:37AM +0200, Alexander Graf wrote:
> But last time I checked, we had a cdrom emulation in scsi-disk.c _and_
> in ide.c.
>
> I personally see no reason for that. Why can't we just have an atapi
> emulation layer in ide.c and use whatever scsi backends we have? That
> way, we'd only need to implement cd-rom and scsi passthrough once and
> have it available either via SCSI or via ATAPI.
That would be best. Note that we don't implement SCSI passthrough in
scsi-disk.c but rather in scsi-generic.c. But being able to attach
both of them to ata.c using an ATAPI shim would indeed be best.
next prev parent reply other threads:[~2009-07-01 8:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 15:34 [Qemu-devel] [PATCH] ATAPI pass through Bique Alexandre
2009-06-30 16:26 ` Kevin Wolf
2009-06-30 18:10 ` Bique Alexandre
2009-07-01 6:57 ` Alexander Graf
2009-07-01 8:44 ` Christoph Hellwig [this message]
2009-07-01 9:36 ` Paul Brook
2009-07-01 11:29 ` Christoph Hellwig
2009-06-30 17:01 ` Christoph Hellwig
2009-06-30 17:55 ` Bique Alexandre
2009-07-01 8:43 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090701084459.GA3079@lst.de \
--to=hch@lst.de \
--cc=agraf@suse.de \
--cc=alexandre.bique@citrix.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.