From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block-raw: Allow pread beyond the end of growable images
Date: Wed, 1 Jul 2009 10:56:12 +0200 [thread overview]
Message-ID: <20090701085612.GA3564@lst.de> (raw)
In-Reply-To: <4A4B1238.8060302@redhat.com>
On Wed, Jul 01, 2009 at 09:37:28AM +0200, Kevin Wolf wrote:
> If you feel like posting a better patch, go ahead. I'm feeling that it's
> going to be a whole lot uglier in bdrv_pwrite, but that might prove
> wrong. And after all it is a problem with raw and not with the generic
> block code - qcow2 for example was already reading zeros.
>
> For the time being, this patch fixes a bug and should stay.
So the only use case is a doing a savevm on a qcow2 device with a
raw-posix backing dev? What happens with nbd backing dev or a raw
backing dev on win32? OR (not sure we'll actually support that) another
image format backing dev?
next prev parent reply other threads:[~2009-07-01 8:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 17:51 [Qemu-devel] [PATCH] block-raw: Allow pread beyond the end of growable images Kevin Wolf
2009-06-30 18:09 ` Christoph Hellwig
2009-07-01 7:37 ` Kevin Wolf
2009-07-01 8:56 ` Christoph Hellwig [this message]
2009-07-01 9:08 ` Kevin Wolf
2009-07-01 11:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090701085612.GA3564@lst.de \
--to=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.